From c7868a810d25e534116af097b9f8d936c9d411c0 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Sun, 13 Jun 2021 15:34:24 +0100 Subject: [PATCH] Move PHP minimum to 7.4 7.3 isn't actively tested anymore, and since 7.4 has been out for so long already, it doesn't make sense to keep pandering to users who can't be bothered to update their PHP binaries. In most cases, these users are also experiencing problems caused by older versions of pthreads that were long since fixed. In addition, pthreads is no longer tested or supported on 7.3, so users can't get newer bug fixes even if they wanted to. --- .github/workflows/main.yml | 10 +++++----- composer.json | 4 ++-- composer.lock | 6 +++--- src/pocketmine/PocketMine.php | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 20a5e3fd0..38ebe7a90 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -13,7 +13,7 @@ jobs: strategy: matrix: image: [ubuntu-20.04] - php: [7.3.28, 7.4.20] + php: [7.4.20] steps: - uses: actions/checkout@v2 #needed for build.sh @@ -37,7 +37,7 @@ jobs: fail-fast: false matrix: image: [ubuntu-20.04] - php: [7.3.28, 7.4.20] + php: [7.4.20] steps: - uses: actions/checkout@v2 @@ -87,7 +87,7 @@ jobs: fail-fast: false matrix: image: [ubuntu-20.04] - php: [7.3.28, 7.4.20] + php: [7.4.20] steps: - uses: actions/checkout@v2 @@ -137,7 +137,7 @@ jobs: fail-fast: false matrix: image: [ubuntu-20.04] - php: [7.3.28, 7.4.20] + php: [7.4.20] steps: - uses: actions/checkout@v2 @@ -189,7 +189,7 @@ jobs: fail-fast: false matrix: image: [ubuntu-20.04] - php: [7.3.28, 7.4.20] + php: [7.4.20] steps: - uses: actions/checkout@v2 diff --git a/composer.json b/composer.json index 8c6f904ff..d8b5dc4a5 100644 --- a/composer.json +++ b/composer.json @@ -5,7 +5,7 @@ "homepage": "https://pmmp.io", "license": "LGPL-3.0", "require": { - "php": "^7.3 || ^8.0", + "php": "^7.4 || ^8.0", "php-64bit": "*", "ext-ctype": "*", "ext-curl": "*", @@ -60,7 +60,7 @@ }, "config": { "platform": { - "php": "7.3.0" + "php": "7.4.0" }, "sort-packages": true }, diff --git a/composer.lock b/composer.lock index cb456a249..776398a74 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies", "This file is @generated automatically" ], - "content-hash": "b10dca2b9822b8104499ff70750f8181", + "content-hash": "29c660b8c4fd0708d270c63993de9526", "packages": [ { "name": "adhocore/json-comment", @@ -2756,7 +2756,7 @@ "prefer-stable": false, "prefer-lowest": false, "platform": { - "php": "^7.3 || ^8.0", + "php": "^7.4 || ^8.0", "php-64bit": "*", "ext-ctype": "*", "ext-curl": "*", @@ -2779,7 +2779,7 @@ }, "platform-dev": [], "platform-overrides": { - "php": "7.3.0" + "php": "7.4.0" }, "plugin-api-version": "2.1.0" } diff --git a/src/pocketmine/PocketMine.php b/src/pocketmine/PocketMine.php index f2fa55875..32e9e9356 100644 --- a/src/pocketmine/PocketMine.php +++ b/src/pocketmine/PocketMine.php @@ -36,7 +36,7 @@ namespace pocketmine { require_once __DIR__ . '/VersionInfo.php'; - const MIN_PHP_VERSION = "7.3.0"; + const MIN_PHP_VERSION = "7.4.0"; /** * @param string $message