mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-04-21 08:17:34 +00:00
Code Issues Projects Releases Wiki Activity

Revert bad optimization due to broken logic

Browse Source 
Revert "Small optimization to light propagation"

This reverts commit 6d7b76f356decb071b82505a5ecf35dbf927230d.
This commit is contained in:
Dylan K. Taylor 2017-07-09 12:45:11 +01:00
parent 6d7b76f356
commit c6a6571c07
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/pocketmine/level/light/LightUpdate.php
View File

@ -76,7 +76,7 @@ abstract class LightUpdate{
$this->setLight($x, $y, $z, $newLevel);
if($oldLevel < $newLevel){ //light increased
$this->spreadVisited[$index] = true;
$this->spreadQueue->enqueue([$x, $y, $z, $newLevel]);
$this->spreadQueue->enqueue([$x, $y, $z]);
}else{ //light removed
$this->removalVisited[$index] = true;
$this->removalQueue->enqueue([$x, $y, $z, $oldLevel]);
@ -106,7 +106,12 @@ abstract class LightUpdate{
}
while(!$this->spreadQueue->isEmpty()){
list($x, $y, $z, $newAdjacentLight) = $this->spreadQueue->dequeue();
list($x, $y, $z) = $this->spreadQueue->dequeue();
$newAdjacentLight = $this->getLight($x, $y, $z);
if($newAdjacentLight <= 0){
continue;
}
$points = [
[$x + 1, $y, $z],
@ -141,7 +146,7 @@ abstract class LightUpdate{
}elseif($current >= $oldAdjacentLevel){
if(!isset($this->spreadVisited[$index = Level::blockHash($x, $y, $z)])){
$this->spreadVisited[$index] = true;
$this->spreadQueue->enqueue([$x, $y, $z, $current]);
$this->spreadQueue->enqueue([$x, $y, $z]);
}
}
}
@ -156,7 +161,7 @@ abstract class LightUpdate{
if(!isset($this->spreadVisited[$index = Level::blockHash($x, $y, $z)])){
$this->spreadVisited[$index] = true;
if($potentialLight > 1){
$this->spreadQueue->enqueue([$x, $y, $z, $potentialLight]);
$this->spreadQueue->enqueue([$x, $y, $z]);
}
}
}