From c4d8c283385986c61cd37bbd6b6fe5051fe74341 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Wed, 16 Aug 2017 13:07:33 +0100 Subject: [PATCH] Some inspection fixes --- src/pocketmine/block/GlowingRedstoneOre.php | 1 - src/pocketmine/network/rcon/RCON.php | 5 +++++ src/pocketmine/utils/VersionString.php | 10 ++++++++-- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/src/pocketmine/block/GlowingRedstoneOre.php b/src/pocketmine/block/GlowingRedstoneOre.php index 2dfeed96c..90bb683ae 100644 --- a/src/pocketmine/block/GlowingRedstoneOre.php +++ b/src/pocketmine/block/GlowingRedstoneOre.php @@ -23,7 +23,6 @@ declare(strict_types=1); namespace pocketmine\block; -use pocketmine\item\Item; use pocketmine\level\Level; class GlowingRedstoneOre extends RedstoneOre{ diff --git a/src/pocketmine/network/rcon/RCON.php b/src/pocketmine/network/rcon/RCON.php index 991d76482..1c73611b0 100644 --- a/src/pocketmine/network/rcon/RCON.php +++ b/src/pocketmine/network/rcon/RCON.php @@ -35,10 +35,15 @@ use pocketmine\utils\TextFormat; class RCON{ /** @var Server */ private $server; + /** @var resource */ private $socket; + /** @var string */ private $password; + /** @var int */ + private $threads; /** @var RCONInstance[] */ private $workers = []; + /** @var int */ private $clientsPerThread; public function __construct(Server $server, string $password, int $port = 19132, string $interface = "0.0.0.0", int $threads = 1, int $clientsPerThread = 50){ diff --git a/src/pocketmine/utils/VersionString.php b/src/pocketmine/utils/VersionString.php index acb282da6..e7f6f7c2b 100644 --- a/src/pocketmine/utils/VersionString.php +++ b/src/pocketmine/utils/VersionString.php @@ -28,9 +28,15 @@ namespace pocketmine\utils; * Manages PocketMine-MP version strings, and compares them */ class VersionString{ + /** @var int */ + private $generation; + /** @var int */ private $major; - private $build; + /** @var int */ private $minor; + /** @var int */ + private $build; + /** @var bool */ private $development = false; /** @@ -58,7 +64,7 @@ class VersionString{ } public function getNumber() : int{ - return (int) (($this->generation << 9) + ($this->major << 5) + $this->minor); + return (($this->generation << 9) + ($this->major << 5) + $this->minor); } public function getGeneration() : int{