mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-03 08:35:20 +00:00
Code Issues Projects Releases Wiki Activity

Refuse to load plugins with ambiguous minAPI versions

Browse Source 
closes #2381
This commit is contained in:
Dylan K. Taylor
2019-04-12 19:51:43 +01:00
parent bf2851f324
commit c4b4575c74
4 changed files with 70 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tests/phpunit/plugin/ApiVersionTest.php
View File

@ -52,4 +52,27 @@ class ApiVersionTest extends TestCase{
public function testCompatibleApi(string $myVersion, string $wantVersion, bool $expected) : void{
self::assertSame($expected, ApiVersion::isCompatible($myVersion, [$wantVersion]), "my version: $myVersion, their version: $wantVersion, expect " . ($expected ? "yes" : "no"));
}
public function ambiguousVersionsProvider() : \Generator{
yield [["3.0.0"], []];
yield [["3.0.0", "3.0.1"], ["3.0.0", "3.0.1"]];
yield [["3.0.0", "3.1.0", "4.0.0"], ["3.0.0", "3.1.0"]];
yield [["3.0.0", "4.0.0"], []];
yield [["3.0.0-ALPHA1", "3.0.0-ALPHA2"], []];
}
/**
* @dataProvider ambiguousVersionsProvider
*
* @param string[] $input
* @param string[] $expectedOutput
*/
public function testFindAmbiguousVersions(array $input, array $expectedOutput) : void{
$ambiguous = ApiVersion::checkAmbiguousVersions($input);
sort($expectedOutput);
sort($ambiguous);
self::assertSame($expectedOutput, $ambiguous);
}
}