mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-09 23:39:43 +00:00
Code Issues Projects Releases Wiki Activity

SubChunk: remove nonsensical reference from internal function

Browse Source
This commit is contained in:
Dylan K. Taylor 2020-01-11 21:49:33 +00:00
parent 8794292788
commit c329ff7d4f
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/pocketmine/level/format/SubChunk.php
View File

@ -47,20 +47,19 @@ class SubChunk implements SubChunkInterface{
/** @var string */
protected $skyLight;
private static function assignData(&$target, string $data, int $length, string $value = "\x00"){
private static function assignData(string $data, int $length, string $value = "\x00") : string{
if(strlen($data) !== $length){
assert($data === "", "Invalid non-zero length given, expected $length, got " . strlen($data));
$target = str_repeat($value, $length);
}else{
$target = $data;
return str_repeat($value, $length);
}
return $data;
}
public function __construct(string $ids = "", string $data = "", string $skyLight = "", string $blockLight = ""){
self::assignData($this->ids, $ids, 4096);
self::assignData($this->data, $data, 2048);
self::assignData($this->skyLight, $skyLight, 2048, "\xff");
self::assignData($this->blockLight, $blockLight, 2048);
$this->ids = self::assignData($ids, 4096);
$this->data = self::assignData($data, 2048);
$this->skyLight = self::assignData($skyLight, 2048, "\xff");
$this->blockLight = self::assignData($blockLight, 2048);
$this->collectGarbage();
}