mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-04 00:59:51 +00:00
Code Issues Projects Releases Wiki Activity

InGamePacketHandler: avoid useless object allocations when forceMoveSync=false (99.9% of the time)

Browse Source
This commit is contained in:
Dylan K. Taylor 2022-07-24 20:44:27 +01:00
parent b75bc61a64
commit c26631d06d
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/network/mcpe/handler/InGamePacketHandler.php
View File

@ -197,17 +197,20 @@ class InGamePacketHandler extends PacketHandler{
$this->player->setRotation($yaw, $pitch); $this->player->setRotation($yaw, $pitch);
$curPos = $this->player->getLocation();
$newPos = $rawPos->round(4)->subtract(0, 1.62, 0); $newPos = $rawPos->round(4)->subtract(0, 1.62, 0);
if($this->forceMoveSync && $newPos->distanceSquared($curPos) > 1){ //Tolerate up to 1 block to avoid problems with client-sided physics when spawning in blocks if($this->forceMoveSync){
$this->session->getLogger()->debug("Got outdated pre-teleport movement, received " . $newPos . ", expected " . $curPos); $curPos = $this->player->getLocation();
//Still getting movements from before teleport, ignore them
return false;
}
// Once we get a movement within a reasonable distance, treat it as a teleport ACK and remove position lock if($newPos->distanceSquared($curPos) > 1){ //Tolerate up to 1 block to avoid problems with client-sided physics when spawning in blocks
$this->forceMoveSync = false; $this->session->getLogger()->debug("Got outdated pre-teleport movement, received " . $newPos . ", expected " . $curPos);
//Still getting movements from before teleport, ignore them
return false;
}
// Once we get a movement within a reasonable distance, treat it as a teleport ACK and remove position lock
$this->forceMoveSync = false;
}
$inputFlags = $packet->getInputFlags(); $inputFlags = $packet->getInputFlags();
if($inputFlags !== $this->lastPlayerAuthInputFlags){ if($inputFlags !== $this->lastPlayerAuthInputFlags){