mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-09 11:31:49 +00:00
Code Issues Projects Releases Wiki Activity

SubChunkExplorer: ditch subChunkChangeFunc

Browse Source 
this is better implemented by checking the moveTo() result, which also won't have circular dependencies.
This commit is contained in:
Dylan K. Taylor 2020-10-31 23:46:27 +00:00
parent 817372c55b
commit c1a451f3b1
1 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/world/utils/SubChunkExplorer.php
View File

@ -23,7 +23,6 @@ declare(strict_types=1);
namespace pocketmine\world\utils; namespace pocketmine\world\utils;
use pocketmine\utils\Utils;
use pocketmine\world\ChunkManager; use pocketmine\world\ChunkManager;
use pocketmine\world\format\Chunk; use pocketmine\world\format\Chunk;
use pocketmine\world\format\SubChunk; use pocketmine\world\format\SubChunk;
@ -44,12 +43,6 @@ class SubChunkExplorer{
/** @var int */ /** @var int */
protected $currentZ; protected $currentZ;
/**
* @var \Closure|null
* @phpstan-var (\Closure() : void)|null
*/
private $onSubChunkChangeFunc = null;
public function __construct(ChunkManager $world){ public function __construct(ChunkManager $world){
$this->world = $world; $this->world = $world;
} }
@ -78,9 +71,6 @@ class SubChunkExplorer{
} }
$this->currentSubChunk = $this->currentChunk->getSubChunk($y >> 4); $this->currentSubChunk = $this->currentChunk->getSubChunk($y >> 4);
if($this->onSubChunkChangeFunc !== null){
($this->onSubChunkChangeFunc)();
}
return SubChunkExplorerStatus::MOVED; return SubChunkExplorerStatus::MOVED;
} }
@ -95,14 +85,6 @@ class SubChunkExplorer{
return $this->moveTo($chunkX << 4, $chunkY << 4, $chunkZ << 4); return $this->moveTo($chunkX << 4, $chunkY << 4, $chunkZ << 4);
} }
/**
* @phpstan-param \Closure() : void $callback
*/
public function onSubChunkChange(\Closure $callback) : void{
Utils::validateCallableSignature(function() : void{}, $callback);
$this->onSubChunkChangeFunc = $callback;
}
/** /**
* Returns whether we currently have a valid terrain pointer. * Returns whether we currently have a valid terrain pointer.
*/ */