diff --git a/src/network/mcpe/protocol/Packet.php b/src/network/mcpe/protocol/Packet.php index 2c754240a..e54489f81 100644 --- a/src/network/mcpe/protocol/Packet.php +++ b/src/network/mcpe/protocol/Packet.php @@ -30,6 +30,15 @@ interface Packet{ public function setOffset(int $offset) : void; + /** + * TODO: this can't have a native return type yet because of incompatibility with BinaryUtils + * really this should be addressed by making packets not extend BinaryStream, but that's a task for another day. + * + * @param string $buffer + * @param int $offset + * + * @return void + */ public function setBuffer(string $buffer = "", int $offset = 0); public function getOffset() : int; diff --git a/src/network/mcpe/serializer/NetworkBinaryStream.php b/src/network/mcpe/serializer/NetworkBinaryStream.php index 11d6bf51f..bc29ec588 100644 --- a/src/network/mcpe/serializer/NetworkBinaryStream.php +++ b/src/network/mcpe/serializer/NetworkBinaryStream.php @@ -122,12 +122,7 @@ class NetworkBinaryStream extends BinaryStream{ return new SkinData($skinId, $skinResourcePatch, $skinData, $animations, $capeData, $geometryData, $animationData, $premium, $persona, $capeOnClassic, $capeId); } - /** - * @param SkinData $skin - * - * @return void - */ - public function putSkin(SkinData $skin){ + public function putSkin(SkinData $skin): void{ $this->putString($skin->getSkinId()); $this->putString($skin->getResourcePatch()); $this->putSkinImage($skin->getSkinImage());