mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-04-22 00:33:59 +00:00
Code Issues Projects Releases Wiki Activity

Item: use static-analysis-friendly method for retrieving custom block data

Browse Source 
fixes 2 phpstan level 8 errors
This commit is contained in:
Dylan K. Taylor 2020-06-27 13:46:04 +01:00
parent 0000783926
commit c040248dbd
2 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/item/Item.php
View File

@ -351,8 +351,8 @@ class Item implements \JsonSerializable{
$tag->removeTag(self::TAG_ENCH);
}
$this->hasCustomBlockData() ?
$tag->setTag(self::TAG_BLOCK_ENTITY_TAG, clone $this->getCustomBlockData()) :
($blockData = $this->getCustomBlockData()) !== null ?
$tag->setTag(self::TAG_BLOCK_ENTITY_TAG, clone $blockData) :
$tag->removeTag(self::TAG_BLOCK_ENTITY_TAG);
if(!$this->canPlaceOn->isEmpty()){

10
tests/phpstan/configs/l8-baseline.neon
View File

@ -145,16 +145,6 @@ parameters:
count: 1
path: ../../../src/inventory/transaction/CraftingTransaction.php
-
message: "#^Cannot clone pocketmine\\\\nbt\\\\tag\\\\CompoundTag\\|null\\.$#"
count: 1
path: ../../../src/item/Item.php
-
message: "#^Parameter \\#2 \\$tag of method pocketmine\\\\nbt\\\\tag\\\\CompoundTag\\:\\:setTag\\(\\) expects pocketmine\\\\nbt\\\\tag\\\\Tag, pocketmine\\\\nbt\\\\tag\\\\CompoundTag\\|null given\\.$#"
count: 1
path: ../../../src/item/Item.php
-
message: "#^Parameter \\#1 \\$object of function get_class expects object, pocketmine\\\\nbt\\\\tag\\\\Tag\\|null given\\.$#"
count: 1