From f714ed6e903673856cbc186c82cd82327f4b963a Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Fri, 5 Jul 2019 19:20:21 +0100 Subject: [PATCH] Generator: fixed incorrect negative seed parsing in convertSeed() --- src/pocketmine/level/generator/Generator.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pocketmine/level/generator/Generator.php b/src/pocketmine/level/generator/Generator.php index dba5fa8a8..1330cb65c 100644 --- a/src/pocketmine/level/generator/Generator.php +++ b/src/pocketmine/level/generator/Generator.php @@ -30,7 +30,7 @@ use pocketmine\level\ChunkManager; use pocketmine\math\Vector3; use pocketmine\utils\Random; use pocketmine\utils\Utils; -use function ctype_digit; +use function preg_match; abstract class Generator{ @@ -44,7 +44,7 @@ abstract class Generator{ public static function convertSeed(string $seed) : ?int{ if($seed === ""){ //empty seed should cause a random seed to be selected - can't use 0 here because 0 is a valid seed $convertedSeed = null; - }elseif(ctype_digit($seed)){ //this avoids treating seeds like "404.4" as integer seeds + }elseif(preg_match('/^-?\d+$/', $seed) === 1){ //this avoids treating seeds like "404.4" as integer seeds $convertedSeed = (int) $seed; }else{ $convertedSeed = Utils::javaStringHash($seed);