mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-23 19:34:15 +00:00
Code Issues Projects Releases Wiki Activity

Make CraftingManager::sort() more cool with spaceship operators 😎

Browse Source
This commit is contained in:
Dylan K. Taylor 2018-03-27 19:48:10 +01:00
parent 145a4fad0f
commit bc836aaec1
1 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/pocketmine/inventory/CraftingManager.php
View File

@ -145,21 +145,10 @@ class CraftingManager{
* @return int * @return int
*/ */
public static function sort(Item $i1, Item $i2){ public static function sort(Item $i1, Item $i2){
if($i1->getId() > $i2->getId()){ //Use spaceship operator to compare each property, then try the next one if they are equivalent.
return 1; ($retval = $i1->getId() <=> $i2->getId()) === 0 && ($retval = $i1->getDamage() <=> $i2->getDamage()) === 0 && ($retval = $i1->getCount() <=> $i2->getCount());
}elseif($i1->getId() < $i2->getId()){
return -1; return $retval;
}elseif($i1->getDamage() > $i2->getDamage()){
return 1;
}elseif($i1->getDamage() < $i2->getDamage()){
return -1;
}elseif($i1->getCount() > $i2->getCount()){
return 1;
}elseif($i1->getCount() < $i2->getCount()){
return -1;
}else{
return 0;
}
} }
/** /**