mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-03 08:35:20 +00:00
Code Issues Projects Releases Wiki Activity

Chunk: make all parameters of __construct() mandatory and non-nullable

Browse Source 
having the constructor fill in defaults for these invariably causes bugs.
This commit is contained in:
Dylan K. Taylor
2021-10-25 20:22:50 +01:00
parent d53347454b
commit baba25953f
7 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/phpunit/world/format/ChunkTest.php
View File

@ -24,11 +24,12 @@ declare(strict_types=1);
namespace pocketmine\world\format;
use PHPUnit\Framework\TestCase;
use pocketmine\data\bedrock\BiomeIds;
class ChunkTest extends TestCase{
public function testClone() : void{
$chunk = new Chunk();
$chunk = new Chunk([], BiomeArray::fill(BiomeIds::OCEAN), false);
$chunk->setFullBlock(0, 0, 0, 1);
$chunk->setBiomeId(0, 0, 1);
$chunk->setHeightMap(0, 0, 1);