Fixed bad event handlers (whose errors get caught) breaking recursion protection for future event calls

This was observed in a recent crashdump where a plugin triggered a recursion error, but the stack trace did not contain any sign of a recursive event call. I conclude that this must have been caused by previous event handlers triggering errors 50 times in order to make the recursion detection break, because the recursion detection did not decrement the counter in cases where an exception was thrown.

src/pocketmine/event/Event.php

@@ -88,16 +88,19 @@ abstract class Event{
 		assert($handlerList !== null, "Called event should have a valid HandlerList");
 
 		++self::$eventCallDepth;
-		foreach(EventPriority::ALL as $priority){
-			$currentList = $handlerList;
-			while($currentList !== null){
-				foreach($currentList->getListenersByPriority($priority) as $registration){
-					$registration->callEvent($this);
-				}
+		try{
+			foreach(EventPriority::ALL as $priority){
+				$currentList = $handlerList;
+				while($currentList !== null){
+					foreach($currentList->getListenersByPriority($priority) as $registration){
+						$registration->callEvent($this);
+					}
 
-				$currentList = $currentList->getParent();
+					$currentList = $currentList->getParent();
+				}
 			}
+		}finally{
+			--self::$eventCallDepth;
 		}
-		--self::$eventCallDepth;
 	}
 }