Player: use strict base64_decode() for login decoding

though, perhaps we should beware of false returns?
This commit is contained in:
Dylan K. Taylor 2020-02-05 13:55:38 +00:00
parent 896cca0778
commit b96bb7d824

View File

@ -1860,12 +1860,12 @@ class Player extends Human implements CommandSender, ChunkLoader, IPlayer{
$skinData = new SkinData( $skinData = new SkinData(
$packet->clientData["SkinId"], $packet->clientData["SkinId"],
base64_decode($packet->clientData["SkinResourcePatch"] ?? ""), base64_decode($packet->clientData["SkinResourcePatch"] ?? "", true),
new SkinImage($packet->clientData["SkinImageHeight"], $packet->clientData["SkinImageWidth"], base64_decode($packet->clientData["SkinData"])), new SkinImage($packet->clientData["SkinImageHeight"], $packet->clientData["SkinImageWidth"], base64_decode($packet->clientData["SkinData"], true)),
$animations, $animations,
new SkinImage($packet->clientData["CapeImageHeight"], $packet->clientData["CapeImageWidth"], base64_decode($packet->clientData["CapeData"] ?? "")), new SkinImage($packet->clientData["CapeImageHeight"], $packet->clientData["CapeImageWidth"], base64_decode($packet->clientData["CapeData"] ?? "", true)),
base64_decode($packet->clientData["SkinGeometryData"] ?? ""), base64_decode($packet->clientData["SkinGeometryData"] ?? "", true),
base64_decode($packet->clientData["SkinAnimationData"] ?? ""), base64_decode($packet->clientData["SkinAnimationData"] ?? "", true),
$packet->clientData["PremiumSkin"] ?? false, $packet->clientData["PremiumSkin"] ?? false,
$packet->clientData["PersonaSkin"] ?? false, $packet->clientData["PersonaSkin"] ?? false,
$packet->clientData["CapeOnClassicSkin"] ?? false, $packet->clientData["CapeOnClassicSkin"] ?? false,