From b85f3bd149d340268e68886691db874c5da40871 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Tue, 8 Jun 2021 20:20:30 +0100 Subject: [PATCH] make-release: abort on no changelog changes --- build/make-release.php | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/build/make-release.php b/build/make-release.php index d499ff3f6..1f50c542e 100644 --- a/build/make-release.php +++ b/build/make-release.php @@ -69,12 +69,16 @@ function main(array $argv) : void{ $currentVer->getPatch() + 1 )); - $versionInfoPath = dirname(__DIR__) . '/src/pocketmine/VersionInfo.php'; - replaceVersion($versionInfoPath, $currentVer->getBaseVersion(), false); - echo "please add appropriate notes to the changelog and press enter..."; fgets(STDIN); system('git add "' . dirname(__DIR__) . '/changelogs"'); + system('git diff --cached --quiet "' . dirname(__DIR__) . '/changelogs"', $result); + if($result === 0){ + echo "error: no changelog changes detected; aborting\n"; + exit(1); + } + $versionInfoPath = dirname(__DIR__) . '/src/pocketmine/VersionInfo.php'; + replaceVersion($versionInfoPath, $currentVer->getBaseVersion(), false); system('git commit -m "Release ' . $currentVer->getBaseVersion() . '" --include "' . $versionInfoPath . '"'); system('git tag ' . $currentVer->getBaseVersion()); replaceVersion($versionInfoPath, $nextVer->getBaseVersion(), true);