PTHREADS_INHERIT_CONSTANTS is no longer needed for MainLogger to log exceptions

cleaned paths are now referenced from Filesystem instead of namespace constants.
This commit is contained in:
Dylan K. Taylor 2021-09-26 21:41:24 +01:00
parent f138004913
commit b3e8314b9f
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
2 changed files with 2 additions and 4 deletions

View File

@ -51,7 +51,6 @@ use function mt_rand;
use function random_bytes;
use function rtrim;
use function substr;
use const PTHREADS_INHERIT_CONSTANTS;
class RakLibInterface implements ServerEventListener, AdvancedNetworkInterface{
/**
@ -122,7 +121,7 @@ class RakLibInterface implements ServerEventListener, AdvancedNetworkInterface{
while($this->eventReceiver->handle($this));
});
$this->server->getLogger()->debug("Waiting for RakLib to start...");
$this->rakLib->startAndWait(PTHREADS_INHERIT_CONSTANTS); //HACK: MainLogger needs constants for exception logging
$this->rakLib->startAndWait();
$this->server->getLogger()->debug("RakLib booted successfully");
}

View File

@ -33,7 +33,6 @@ use function count;
use function spl_object_id;
use function time;
use const PHP_INT_MAX;
use const PTHREADS_INHERIT_CONSTANTS;
use const PTHREADS_INHERIT_INI;
/**
@ -41,7 +40,7 @@ use const PTHREADS_INHERIT_INI;
* workers.
*/
class AsyncPool{
private const WORKER_START_OPTIONS = PTHREADS_INHERIT_INI | PTHREADS_INHERIT_CONSTANTS;
private const WORKER_START_OPTIONS = PTHREADS_INHERIT_INI;
/** @var \ClassLoader */
private $classLoader;