From b344427a3038e07a8efefcc27f3b362c99272057 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Mon, 17 Jun 2019 14:20:29 +0100 Subject: [PATCH] Added a hack to allow dropping garbage serverbound packets sent by a buggy client --- .../network/mcpe/NetworkSession.php | 5 +++ .../protocol/GarbageServerboundPacket.php | 32 +++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 src/pocketmine/network/mcpe/protocol/GarbageServerboundPacket.php diff --git a/src/pocketmine/network/mcpe/NetworkSession.php b/src/pocketmine/network/mcpe/NetworkSession.php index 1c731fd2e..b30ad7fb3 100644 --- a/src/pocketmine/network/mcpe/NetworkSession.php +++ b/src/pocketmine/network/mcpe/NetworkSession.php @@ -48,6 +48,7 @@ use pocketmine\network\mcpe\protocol\ChunkRadiusUpdatedPacket; use pocketmine\network\mcpe\protocol\ClientboundPacket; use pocketmine\network\mcpe\protocol\ContainerSetDataPacket; use pocketmine\network\mcpe\protocol\DisconnectPacket; +use pocketmine\network\mcpe\protocol\GarbageServerboundPacket; use pocketmine\network\mcpe\protocol\InventoryContentPacket; use pocketmine\network\mcpe\protocol\InventorySlotPacket; use pocketmine\network\mcpe\protocol\MobArmorEquipmentPacket; @@ -313,6 +314,10 @@ class NetworkSession{ */ public function handleDataPacket(Packet $packet) : void{ if(!($packet instanceof ServerboundPacket)){ + if($packet instanceof GarbageServerboundPacket){ + $this->logger->debug("Garbage serverbound " . $packet->getName() . ": " . base64_encode($packet->getBuffer())); + return; + } throw new BadPacketException("Unexpected non-serverbound packet"); } diff --git a/src/pocketmine/network/mcpe/protocol/GarbageServerboundPacket.php b/src/pocketmine/network/mcpe/protocol/GarbageServerboundPacket.php new file mode 100644 index 000000000..04870b125 --- /dev/null +++ b/src/pocketmine/network/mcpe/protocol/GarbageServerboundPacket.php @@ -0,0 +1,32 @@ +