mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-09 15:29:47 +00:00
Code Issues Projects Releases Wiki Activity

CraftingDataPacket: Fixed uncaught exception in decode

Browse Source 
this is not exploitable because it's not a serverbound packet, but it should be fixed nonetheless.
This commit is contained in:
Dylan K. Taylor 2019-05-18 17:19:44 +01:00
parent cd8645ff20
commit b11d3b0401
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/pocketmine/network/mcpe/protocol/CraftingDataPacket.php
View File

@ -110,7 +110,11 @@ class CraftingDataPacket extends DataPacket implements ClientboundPacket{
$inputData = -1; $inputData = -1;
} }
} }
$entry["input"] = ItemFactory::get($inputId, $inputData); try{
$entry["input"] = ItemFactory::get($inputId, $inputData);
}catch(\InvalidArgumentException $e){
throw new BadPacketException($e->getMessage(), 0, $e);
}
$entry["output"] = $this->getSlot(); $entry["output"] = $this->getSlot();
$entry["block"] = $this->getString(); $entry["block"] = $this->getString();