From acd7c9b3369d29c3e7970271b06b211937bb8aaf Mon Sep 17 00:00:00 2001
From: "Dylan K. Taylor" <odigiman@gmail.com>
Date: Sat, 1 Dec 2018 15:56:44 +0000
Subject: [PATCH] Permission: Throw exception on unknown values in getByName()
 Previously, writing wrong values into plugin.yml for permission defaults
 would cause the permission to be silently denied to everyone.

---
 src/pocketmine/permission/Permission.php | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/pocketmine/permission/Permission.php b/src/pocketmine/permission/Permission.php
index cacd3b2f2a..df01041d46 100644
--- a/src/pocketmine/permission/Permission.php
+++ b/src/pocketmine/permission/Permission.php
@@ -42,6 +42,8 @@ class Permission{
 	 * @param bool|string $value
 	 *
 	 * @return string
+	 *
+	 * @throws \InvalidArgumentException
 	 */
 	public static function getByName($value) : string{
 		if(is_bool($value)){
@@ -70,10 +72,11 @@ class Permission{
 
 			case "true":
 				return self::DEFAULT_TRUE;
-
-			default:
+			case "false":
 				return self::DEFAULT_FALSE;
 		}
+
+		throw new \InvalidArgumentException("Unknown permission default name \"$value\"");
 	}
 
 	/**