mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-10 21:45:35 +00:00
Code Issues Projects Releases Wiki Activity

BlockFactory: fix potential crash

Browse Source
This commit is contained in:
Dylan K. Taylor 2021-05-21 21:44:17 +01:00
parent 24405b63c1
commit ac04911e88
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/block/BlockFactory.php
View File

@ -917,7 +917,7 @@ class BlockFactory{
$index = ($id << 4) | $meta; $index = ($id << 4) | $meta;
if($this->isRegistered($id, $meta)){ if($this->isRegistered($id, $meta)){
$existing = $this->fullList[$index]; $existing = $this->fullList[$index];
if($existing->getFullId() === $index){ if($existing !== null && $existing->getFullId() === $index){
throw new \InvalidArgumentException("$id:$meta is already mapped"); throw new \InvalidArgumentException("$id:$meta is already mapped");
}else{ }else{
//if it's not a match, this was already remapped for some reason; remapping overwrites are OK //if it's not a match, this was already remapped for some reason; remapping overwrites are OK