mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-12 06:25:32 +00:00
Code Issues Projects Releases Wiki Activity

Event: Remove unnecessary check from call() hot path

Browse Source 
This check is completely unnecessary since handlers get unregistered when a plugin is disabled. Additionally, this is an extremely hot path and this change produces a modest 5% performance improvement to event calls.
This commit is contained in:
Dylan K. Taylor 2018-10-07 16:36:30 +01:00
parent 0e508876d2
commit ab5aec6c30
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pocketmine/event/Event.php
View File

@ -92,10 +92,6 @@ abstract class Event{
$currentList = $handlerList; $currentList = $handlerList;
while($currentList !== null){ while($currentList !== null){
foreach($currentList->getListenersByPriority($priority) as $registration){ foreach($currentList->getListenersByPriority($priority) as $registration){
if(!$registration->getPlugin()->isEnabled()){
continue;
}
$registration->callEvent($this); $registration->callEvent($this);
} }