mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-09 03:06:55 +00:00
Code Issues Projects Releases Wiki Activity

eliminate remaining empty() usages

Browse Source
This commit is contained in:
Dylan K. Taylor
2020-02-07 21:46:16 +00:00
parent 1ffabbb567
commit aac7da6c96
22 changed files with 40 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/block/BaseRail.php
View File

@ -79,7 +79,7 @@ abstract class BaseRail extends Flowable{
}
protected function writeStateToMeta() : int{
if(empty($this->connections)){
if(count($this->connections) === 0){
return BlockLegacyMetadata::RAIL_STRAIGHT_NORTH_SOUTH;
}
return $this->getMetaForState($this->connections);

3
src/block/Fence.php
View File

@ -25,6 +25,7 @@ namespace pocketmine\block;
use pocketmine\math\AxisAlignedBB;
use pocketmine\math\Facing;
use function count;
class Fence extends Transparent{
/** @var bool[] facing => dummy */
@ -80,7 +81,7 @@ class Fence extends Transparent{
->trim(Facing::SOUTH, $connectSouth ? 0 : $inset);
}
if(empty($bbs)){
if(count($bbs) === 0){
//centre post AABB (only needed if not connected on any axis - other BBs overlapping will do this if any connections are made)
return [
AxisAlignedBB::one()

3
src/block/Thin.php
View File

@ -25,6 +25,7 @@ namespace pocketmine\block;
use pocketmine\math\AxisAlignedBB;
use pocketmine\math\Facing;
use function count;
class Thin extends Transparent{
/** @var bool[] facing => dummy */
@ -71,7 +72,7 @@ class Thin extends Transparent{
$bbs[] = $bb;
}
if(empty($bbs)){
if(count($bbs) === 0){
//centre post AABB (only needed if not connected on any axis - other BBs overlapping will do this if any connections are made)
return [
AxisAlignedBB::one()->contract($inset, 0, $inset)

3
src/block/Vine.php
View File

@ -30,6 +30,7 @@ use pocketmine\math\Vector3;
use pocketmine\player\Player;
use pocketmine\world\BlockTransaction;
use function array_intersect_key;
use function count;
class Vine extends Flowable{
@ -113,7 +114,7 @@ class Vine extends Flowable{
}
if($changed){
if(empty($this->faces)){
if(count($this->faces) === 0){
$this->pos->getWorld()->useBreakOn($this->pos);
}else{
$this->pos->getWorld()->setBlock($this->pos, $this);