mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-06 09:56:06 +00:00
Code Issues Projects Releases Wiki Activity

Added explicit AsyncTask->storeLocal(), removed AsyncTask->__construct() object storage (#1322)

Browse Source 
Far too often I see people using IDEs which generate the constructors for them and then accidentally unintentionally store things in the object store. This parent constructor behaviour is unexpected. If a developer wants to store something, they should now do so explicitly by calling storeLocal().
This commit is contained in:
Dylan K. Taylor
2017-09-10 20:31:28 +01:00
committed by GitHub
parent 25adac8859
commit aaa3b6e59a
3 changed files with 68 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/pocketmine/scheduler/BulkCurlTask.php
View File

@ -46,7 +46,7 @@ class BulkCurlTask extends AsyncTask{
* @param mixed|null $complexData
*/
public function __construct(array $operations, $complexData = null){
parent::__construct($complexData);
$this->storeLocal($complexData);
$this->operations = serialize($operations);
}