From a9a55e9558585fc98cc94c40c9557b2a3d53c84c Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Thu, 15 Mar 2018 09:24:33 +0000 Subject: [PATCH] GlowingRedstoneOre: fixed infinite recursion and crash on block update closes #2104 The inheritance of GlowingRedstoneOre from RedstoneOre maybe should be reconsidered. They only share properties in reality. --- src/pocketmine/block/GlowingRedstoneOre.php | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/pocketmine/block/GlowingRedstoneOre.php b/src/pocketmine/block/GlowingRedstoneOre.php index 31dd5bb06..0825bf546 100644 --- a/src/pocketmine/block/GlowingRedstoneOre.php +++ b/src/pocketmine/block/GlowingRedstoneOre.php @@ -23,6 +23,9 @@ declare(strict_types=1); namespace pocketmine\block; +use pocketmine\item\Item; +use pocketmine\Player; + class GlowingRedstoneOre extends RedstoneOre{ protected $id = self::GLOWING_REDSTONE_ORE; @@ -37,6 +40,14 @@ class GlowingRedstoneOre extends RedstoneOre{ return 9; } + public function onActivate(Item $item, Player $player = null) : bool{ + return false; + } + + public function onNearbyBlockChange() : void{ + + } + public function ticksRandomly() : bool{ return true; }