diff --git a/src/pocketmine/Player.php b/src/pocketmine/Player.php index 79b259a41..472eb0453 100644 --- a/src/pocketmine/Player.php +++ b/src/pocketmine/Player.php @@ -3515,13 +3515,14 @@ class Player extends Human implements CommandSender, ChunkLoader, IPlayer{ * Sends a Form to the player, or queue to send it if a form is already open. */ public function sendForm(Form $form) : void{ + $formData = json_encode($form); + if($formData === false){ + throw new \InvalidArgumentException("Failed to encode form JSON: " . json_last_error_msg()); + } $id = $this->formIdCounter++; $pk = new ModalFormRequestPacket(); $pk->formId = $id; - $pk->formData = json_encode($form); - if($pk->formData === false){ - throw new \InvalidArgumentException("Failed to encode form JSON: " . json_last_error_msg()); - } + $pk->formData = $formData; if($this->dataPacket($pk)){ $this->forms[$id] = $form; } diff --git a/tests/phpstan/configs/l7-baseline.neon b/tests/phpstan/configs/l7-baseline.neon index eb84dc9a9..7409fb871 100644 --- a/tests/phpstan/configs/l7-baseline.neon +++ b/tests/phpstan/configs/l7-baseline.neon @@ -45,11 +45,6 @@ parameters: count: 1 path: ../../../src/pocketmine/Player.php - - - message: "#^Property pocketmine\\\\network\\\\mcpe\\\\protocol\\\\ModalFormRequestPacket\\:\\:\\$formData \\(string\\) does not accept string\\|false\\.$#" - count: 1 - path: ../../../src/pocketmine/Player.php - - message: "#^Only booleans are allowed in an if condition, bool\\|int given\\.$#" count: 1