mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-08-30 06:55:11 +00:00
Code Issues Projects Releases Wiki Activity

Enchantment: Create constant name once, and reuse it

Browse Source 
this is more readable and more maintainable.
This commit is contained in:
Dylan K. Taylor 2017-12-21 13:11:31 +00:00
parent c2b0f6af22
commit a842a5319f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/pocketmine/item/enchantment/Enchantment.php
View File

@ -116,8 +116,9 @@ class Enchantment{
* @return Enchantment|null * @return Enchantment|null
*/ */
public static function getEnchantmentByName(string $name){ public static function getEnchantmentByName(string $name){
if(defined(Enchantment::class . "::" . strtoupper($name))){ $const = Enchantment::class . "::" . strtoupper($name);
return self::getEnchantment(constant(Enchantment::class . "::" . strtoupper($name))); if(defined($const)){
return self::getEnchantment(constant($const));
} }
return null; return null;
} }