mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-04-22 08:44:01 +00:00
Code Issues Projects Releases Wiki Activity

Fixed sub-optimal code in WritableBook

Browse Source
This commit is contained in:
Dylan K. Taylor 2017-10-15 10:14:02 +01:00
parent cdebb62c35
commit a547e2cca8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pocketmine/item/WritableBook.php
View File

@ -181,11 +181,11 @@ class WritableBook extends Item{
* @return bool
*/
private function pushPages(int $pageId, CompoundTag $namedTag, bool $downwards = true) : bool{
if(empty($this->getPages())){
$pages = $this->getPages();
if(empty($pages)){
return false;
}
$pages = $this->getPages();
$type = $downwards ? -1 : 1;
foreach($pages as $key => $page){
if(($key <= $pageId and $downwards) or ($key < $pageId and !$downwards)){