mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-11 04:17:48 +00:00
Code Issues Projects Releases Wiki Activity

PlayerCreationEvent: verify that the class actually exists and is instantiable

Browse Source 
this ensures that crashdumps blame the plugin instead of the core on bad classes, such as in this case: https://crash.pmmp.io/view/5331225
This commit is contained in:
Dylan K. Taylor 2021-10-21 14:49:46 +01:00
parent 2971bf30a5
commit a4b65d6a3f
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/event/player/PlayerCreationEvent.php
View File

@ -26,6 +26,7 @@ namespace pocketmine\event\player;
use pocketmine\event\Event; use pocketmine\event\Event;
use pocketmine\network\mcpe\NetworkSession; use pocketmine\network\mcpe\NetworkSession;
use pocketmine\player\Player; use pocketmine\player\Player;
use pocketmine\utils\Utils;
use function is_a; use function is_a;
/** /**
@ -96,10 +97,7 @@ class PlayerCreationEvent extends Event{
* @phpstan-param class-string<Player> $class * @phpstan-param class-string<Player> $class
*/ */
public function setPlayerClass($class) : void{ public function setPlayerClass($class) : void{
if(!is_a($class, $this->baseClass, true)){ Utils::testValidInstance($class, $this->baseClass);
throw new \RuntimeException("Class $class must extend " . $this->baseClass);
}
$this->playerClass = $class; $this->playerClass = $class;
} }
} }