Packet: Remove mayHaveUnreadBytes()

this was an old hack to prevent debug spam being emitted when we halted decoding of logins over breaking protocol changes. Since then, we've gone back to trying to decode the packet regardless, so this property is useless.

src/pocketmine/network/mcpe/NetworkSession.php

@@ -319,7 +319,7 @@ class NetworkSession{
 
 		try{
 			$packet->decode();
-			if(!$packet->feof() and !$packet->mayHaveUnreadBytes()){
+			if(!$packet->feof()){
 				$remains = substr($packet->getBuffer(), $packet->getOffset());
 				$this->logger->debug("Still " . strlen($remains) . " bytes unread in " . $packet->getName() . ": " . bin2hex($remains));
 			}

src/pocketmine/network/mcpe/protocol/DataPacket.php

@@ -56,14 +56,6 @@ abstract class DataPacket extends NetworkBinaryStream implements Packet{
 		return false;
 	}
 
-	/**
-	 * Returns whether the packet may legally have unread bytes left in the buffer.
-	 * @return bool
-	 */
-	public function mayHaveUnreadBytes() : bool{
-		return false;
-	}
-
 	/**
 	 * @throws BadPacketException
 	 */

src/pocketmine/network/mcpe/protocol/LoginPacket.php

@@ -82,10 +82,6 @@ class LoginPacket extends DataPacket implements ServerboundPacket{
 		return true;
 	}
 
-	public function mayHaveUnreadBytes() : bool{
-		return $this->protocol !== null and $this->protocol !== ProtocolInfo::CURRENT_PROTOCOL;
-	}
-
 	protected function decodePayload() : void{
 		$this->protocol = $this->getInt();
 		$this->decodeConnectionRequest();

src/pocketmine/network/mcpe/protocol/Packet.php

@@ -48,12 +48,6 @@ interface Packet{
 
 	public function canBeSentBeforeLogin() : bool;
 
-	/**
-	 * Returns whether the packet may legally have unread bytes left in the buffer.
-	 * @return bool
-	 */
-	public function mayHaveUnreadBytes() : bool;
-
 	/**
 	 * @throws BadPacketException
 	 */