mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-06 09:56:06 +00:00
Code Issues Projects Releases Wiki Activity

Packet: Remove mayHaveUnreadBytes()

Browse Source 
this was an old hack to prevent debug spam being emitted when we halted decoding of logins over breaking protocol changes. Since then, we've gone back to trying to decode the packet regardless, so this property is useless.
This commit is contained in:
Dylan K. Taylor
2019-06-05 15:37:35 +01:00
parent 3b5df90b0b
commit 9f0a184a5d
4 changed files with 1 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/pocketmine/network/mcpe/NetworkSession.php
View File

@ -319,7 +319,7 @@ class NetworkSession{
try{
$packet->decode();
if(!$packet->feof() and !$packet->mayHaveUnreadBytes()){
if(!$packet->feof()){
$remains = substr($packet->getBuffer(), $packet->getOffset());
$this->logger->debug("Still " . strlen($remains) . " bytes unread in " . $packet->getName() . ": " . bin2hex($remains));
}