mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-28 06:09:57 +00:00
Code Issues Projects Releases Wiki Activity

Improved ListCommand and fixed crash when no players are online

Browse Source 
I <3 closures
This commit is contained in:
Dylan K. Taylor 2017-06-11 10:56:16 +01:00
parent 75cc2d6914
commit 9e99252817
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/pocketmine/command/defaults/ListCommand.php
View File

@ -43,18 +43,14 @@ class ListCommand extends VanillaCommand{
return true; return true;
} }
$online = ""; $playerNames = array_map(function(Player $player){
$onlineCount = 0; return $player->getName();
}, array_filter($sender->getServer()->getOnlinePlayers(), function(Player $player) use ($sender){
return $player->isOnline() and (!($sender instanceof Player) or $sender->canSee($player));
}));
foreach($sender->getServer()->getOnlinePlayers() as $player){ $sender->sendMessage(new TranslationContainer("commands.players.list", [count($playerNames), $sender->getServer()->getMaxPlayers()]));
if($player->isOnline() and (!($sender instanceof Player) or $sender->canSee($player))){ $sender->sendMessage(implode(", ", $playerNames));
$online .= $player->getDisplayName() . ", ";
++$onlineCount;
}
}
$sender->sendMessage(new TranslationContainer("commands.players.list", [$onlineCount, $sender->getServer()->getMaxPlayers()]));
$sender->sendMessage(substr($online, 0, -2));
return true; return true;
} }