PHPUnit migrated to attributes :(

This commit is contained in:
Dylan K. Taylor
2025-06-08 19:19:17 +01:00
parent 6b5ff5016e
commit 9e773ed439
14 changed files with 43 additions and 58 deletions

View File

@ -23,6 +23,7 @@ declare(strict_types=1);
namespace pocketmine\utils;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\TestCase;
final class CloningRegistryTraitTest extends TestCase{
@ -37,9 +38,9 @@ final class CloningRegistryTraitTest extends TestCase{
}
/**
* @dataProvider cloningRegistryMembersProvider
* @phpstan-param \Closure() : \stdClass $provider
*/
#[DataProvider("cloningRegistryMembersProvider")]
public function testEachMemberClone(\Closure $provider) : void{
self::assertNotSame($provider(), $provider(), "Cloning registry should never return the same object twice");
}

View File

@ -23,6 +23,7 @@ declare(strict_types=1);
namespace pocketmine\utils;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\TestCase;
use function yaml_parse;
@ -60,10 +61,9 @@ class ConfigTest extends TestCase{
}
/**
* @dataProvider fixYamlIndexesProvider
*
* @param mixed[] $expected
*/
#[DataProvider("fixYamlIndexesProvider")]
public function testFixYamlIndexes(string $test, array $expected) : void{
$fixed = Config::fixYAMLIndexes($test);
$decoded = yaml_parse($fixed);

View File

@ -23,6 +23,8 @@ declare(strict_types=1);
namespace pocketmine\utils;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\DoesNotPerformAssertions;
use PHPUnit\Framework\TestCase;
use pocketmine\utils\fixtures\TestAbstractClass;
use pocketmine\utils\fixtures\TestInstantiableClass;
@ -52,9 +54,7 @@ class UtilsTest extends TestCase{
];
}
/**
* @dataProvider parseDocCommentNewlineProvider
*/
#[DataProvider("parseDocCommentNewlineProvider")]
public function testParseDocCommentNewlines(string $docComment) : void{
$tags = Utils::parseDocComment($docComment);
@ -76,9 +76,7 @@ class UtilsTest extends TestCase{
];
}
/**
* @dataProvider parseDocCommentOneLineProvider
*/
#[DataProvider("parseDocCommentOneLineProvider")]
public function testParseOneLineDocComment(string $comment) : void{
$tags = Utils::parseDocComment($comment);
self::assertArrayHasKey("ignoreCancelled", $tags);
@ -120,11 +118,11 @@ class UtilsTest extends TestCase{
}
/**
* @dataProvider validInstanceProvider
* @doesNotPerformAssertions
* @phpstan-param class-string $className
* @phpstan-param class-string $baseName
*/
#[DataProvider("validInstanceProvider")]
#[DoesNotPerformAssertions]
public function testValidInstanceWithValidCombinations(string $className, string $baseName) : void{
Utils::testValidInstance($className, $baseName);
}
@ -146,9 +144,7 @@ class UtilsTest extends TestCase{
];
}
/**
* @dataProvider validInstanceInvalidCombinationsProvider
*/
#[DataProvider("validInstanceInvalidCombinationsProvider")]
public function testValidInstanceInvalidParameters(string $className, string $baseName) : void{
$this->expectException(\InvalidArgumentException::class);
Utils::testValidInstance($className, $baseName); //@phpstan-ignore-line