diff --git a/src/pocketmine/level/format/io/ChunkRequestTask.php b/src/pocketmine/level/format/io/ChunkRequestTask.php index 16fb7370f..e36af1380 100644 --- a/src/pocketmine/level/format/io/ChunkRequestTask.php +++ b/src/pocketmine/level/format/io/ChunkRequestTask.php @@ -60,7 +60,7 @@ class ChunkRequestTask extends AsyncTask{ $batch->setCompressionLevel($this->compressionLevel); $batch->encode(); - $this->setResult($batch->buffer, false); + $this->setResult($batch->buffer); } public function onCompletion(Server $server){ diff --git a/src/pocketmine/network/CompressBatchedTask.php b/src/pocketmine/network/CompressBatchedTask.php index 9ddd7baae..86b784d31 100644 --- a/src/pocketmine/network/CompressBatchedTask.php +++ b/src/pocketmine/network/CompressBatchedTask.php @@ -51,7 +51,7 @@ class CompressBatchedTask extends AsyncTask{ $batch->setCompressionLevel($this->level); $batch->encode(); - $this->setResult($batch->buffer, false); + $this->setResult($batch->buffer); } public function onCompletion(Server $server){ diff --git a/src/pocketmine/scheduler/AsyncTask.php b/src/pocketmine/scheduler/AsyncTask.php index c9fbbeb9d..9945ea917 100644 --- a/src/pocketmine/scheduler/AsyncTask.php +++ b/src/pocketmine/scheduler/AsyncTask.php @@ -107,11 +107,9 @@ abstract class AsyncTask extends Collectable{ /** * @param mixed $result - * @param bool $serialize */ - public function setResult($result, bool $serialize = true){ - $this->result = $serialize ? serialize($result) : $result; - $this->serialized = $serialize; + public function setResult($result){ + $this->result = ($this->serialized = !is_scalar($result)) ? serialize($result) : $result; } public function setTaskId(int $taskId){ diff --git a/src/pocketmine/updater/UpdateCheckTask.php b/src/pocketmine/updater/UpdateCheckTask.php index e71b8f2c8..0ce465a68 100644 --- a/src/pocketmine/updater/UpdateCheckTask.php +++ b/src/pocketmine/updater/UpdateCheckTask.php @@ -59,7 +59,7 @@ class UpdateCheckTask extends AsyncTask{ isset($response["download_url"]) ){ $response["details_url"] = $response["details_url"] ?? null; - $this->setResult($response, true); + $this->setResult($response); }elseif(isset($response["error"])){ $this->error = $response["error"]; }else{