mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-13 06:55:29 +00:00
Code Issues Projects Releases Wiki Activity

Revert "Add buffering for non-immediate priority packets to reduce compression overhead"

Browse Source 
This reverts commit 2162675b6400807cf650f6fc7ad236c52fa99c01.

This broke Human skins... it seems MCPE doesn't like you adding and
removing a player from the list in the same batch.
This commit is contained in:
Dylan K. Taylor 2017-09-28 14:29:17 +01:00
parent d0bf0ff083
commit 9bc8d8db79
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/pocketmine/Player.php
View File

@ -1064,10 +1064,6 @@ class Player extends Human implements CommandSender, ChunkLoader, IPlayer{
return false; return false;
} }
if(!$packet->canBeBatched()){
throw new \InvalidArgumentException(get_class($packet) . " cannot be added to batch buffer");
}
$timings = Timings::getSendDataPacketTimings($packet); $timings = Timings::getSendDataPacketTimings($packet);
$timings->startTiming(); $timings->startTiming();
$this->server->getPluginManager()->callEvent($ev = new DataPacketSendEvent($this, $packet)); $this->server->getPluginManager()->callEvent($ev = new DataPacketSendEvent($this, $packet));
@ -1126,12 +1122,6 @@ class Player extends Human implements CommandSender, ChunkLoader, IPlayer{
return false; return false;
} }
if(!$needACK and !$immediate and $packet->canBeBatched()){
$this->batchedPackets[] = clone $packet;
return true;
}
$identifier = $this->interface->putPacket($this, $packet, $needACK, $immediate); $identifier = $this->interface->putPacket($this, $packet, $needACK, $immediate);
if($needACK and $identifier !== null){ if($needACK and $identifier !== null){