mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-08 10:53:05 +00:00
Code Issues Projects Releases Wiki Activity

Updated with ListTag changes from PocketMine-NBT

Browse Source
This commit is contained in:
Dylan K. Taylor
2018-02-07 18:14:58 +00:00
parent 4a85311c5f
commit 9abfd54cc1
8 changed files with 71 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
src/pocketmine/item/Banner.php
View File

@ -77,22 +77,17 @@ class Banner extends Item{
* @return int ID of pattern.
*/
public function addPattern(string $pattern, int $color) : int{
$patternId = 0;
if($this->getPatternCount() !== 0){
$patternId = max($this->getPatternIds()) + 1;
}
$patternsTag = $this->getNamedTag()->getListTag(self::TAG_PATTERNS);
assert($patternsTag !== null);
$patternsTag[$patternId] = new CompoundTag("", [
$patternsTag->push(new CompoundTag("", [
new IntTag(self::TAG_PATTERN_COLOR, $color & 0x0f),
new StringTag(self::TAG_PATTERN_NAME, $pattern)
]);
]));
$this->setNamedTagEntry($patternsTag);
return $patternId;
return $patternsTag->count() - 1;
}
/**
@ -104,7 +99,7 @@ class Banner extends Item{
*/
public function patternExists(int $patternId) : bool{
$this->correctNBT();
return isset($this->getNamedTag()->getListTag(self::TAG_PATTERNS)[$patternId]);
return $this->getNamedTag()->getListTag(self::TAG_PATTERNS)->isset($patternId);
}
/**
@ -121,7 +116,7 @@ class Banner extends Item{
$patternsTag = $this->getNamedTag()->getListTag(self::TAG_PATTERNS);
assert($patternsTag !== null);
$pattern = $patternsTag[$patternId];
$pattern = $patternsTag->get($patternId);
assert($pattern instanceof CompoundTag);
return [
@ -148,10 +143,10 @@ class Banner extends Item{
$patternsTag = $this->getNamedTag()->getListTag(self::TAG_PATTERNS);
assert($patternsTag !== null);
$patternsTag[$patternId] = new CompoundTag("", [
$patternsTag->set($patternId, new CompoundTag("", [
new IntTag(self::TAG_PATTERN_COLOR, $color & 0x0f),
new StringTag(self::TAG_PATTERN_NAME, $pattern)
]);
]));
$this->setNamedTagEntry($patternsTag);
return true;
@ -172,7 +167,7 @@ class Banner extends Item{
$patternsTag = $this->getNamedTag()->getListTag(self::TAG_PATTERNS);
if($patternsTag instanceof ListTag){
unset($patternsTag[$patternId]);
$patternsTag->remove($patternId);
$this->setNamedTagEntry($patternsTag);
}
@ -186,12 +181,7 @@ class Banner extends Item{
* @return bool indicating whether the banner was empty or not.
*/
public function deleteTopPattern() : bool{
$keys = $this->getPatternIds();
if(empty($keys)){
return false;
}
return $this->deletePattern(max($keys));
return $this->deletePattern($this->getPatternCount() - 1);
}
/**
@ -201,27 +191,7 @@ class Banner extends Item{
* @return bool indicating whether the banner was empty or not.
*/
public function deleteBottomPattern() : bool{
$keys = $this->getPatternIds();
if(empty($keys)){
return false;
}
return $this->deletePattern(min($keys));
}
/**
* Returns an array containing all pattern IDs
*
* @return array
*/
public function getPatternIds() : array{
$this->correctNBT();
$keys = array_keys((array) ($this->getNamedTag()->getListTag(self::TAG_PATTERNS) ?? []));
return array_filter($keys, function($key){
return is_numeric($key);
}, ARRAY_FILTER_USE_KEY);
return $this->deletePattern(0);
}
/**
@ -230,7 +200,7 @@ class Banner extends Item{
* @return int
*/
public function getPatternCount() : int{
return count($this->getPatternIds());
return $this->getNamedTag()->getListTag(self::TAG_PATTERNS)->count();
}
public function correctNBT() : void{

10
src/pocketmine/item/Item.php
View File

@ -345,7 +345,7 @@ class Item implements ItemIds, \JsonSerializable{
/** @var CompoundTag $entry */
foreach($ench as $k => $entry){
if($entry->getShort("id") === $id and ($level === -1 or $entry->getShort("lvl") === $level)){
unset($ench[$k]);
$ench->remove($k);
break;
}
}
@ -370,10 +370,10 @@ class Item implements ItemIds, \JsonSerializable{
/** @var CompoundTag $entry */
foreach($ench as $k => $entry){
if($entry->getShort("id") === $enchantment->getId()){
$ench[$k] = new CompoundTag("", [
$ench->set($k, new CompoundTag("", [
new ShortTag("id", $enchantment->getId()),
new ShortTag("lvl", $enchantment->getLevel())
]);
]));
$found = true;
break;
}
@ -381,10 +381,10 @@ class Item implements ItemIds, \JsonSerializable{
}
if(!$found){
$ench[count($ench)] = new CompoundTag("", [
$ench->push(new CompoundTag("", [
new ShortTag("id", $enchantment->getId()),
new ShortTag("lvl", $enchantment->getLevel())
]);
]));
}
$this->setNamedTagEntry($ench);

59
src/pocketmine/item/WritableBook.php
View File

@ -46,7 +46,7 @@ class WritableBook extends Item{
* @return bool
*/
public function pageExists(int $pageId) : bool{
return isset($this->getPages()[$pageId]);
return $this->getPagesTag()->isset($pageId);
}
/**
@ -62,7 +62,7 @@ class WritableBook extends Item{
return null;
}
$page = $pages[$pageId] ?? null;
$page = $pages->get($pageId);
if($page instanceof CompoundTag){
return $page->getString(self::TAG_PAGE_TEXT, "");
}
@ -85,13 +85,13 @@ class WritableBook extends Item{
$created = true;
}
$namedTag = $this->getNamedTag();
/** @var CompoundTag[]|ListTag $pages */
$pages = $namedTag->getListTag(self::TAG_PAGES);
assert($pages instanceof ListTag);
$pages[$pageId]->setString(self::TAG_PAGE_TEXT, $pageText);
/** @var CompoundTag[]|ListTag $pagesTag */
$pagesTag = $this->getPagesTag();
/** @var CompoundTag $page */
$page = $pagesTag->get($pageId);
$page->setString(self::TAG_PAGE_TEXT, $pageText);
$this->setNamedTag($namedTag);
$this->setNamedTagEntry($pagesTag);
return $created;
}
@ -107,18 +107,16 @@ class WritableBook extends Item{
throw new \InvalidArgumentException("Page number \"$pageId\" is out of range");
}
$pages = $this->getPages();
$pagesTag = $this->getPagesTag();
for($id = 0; $id <= $pageId; $id++){
if(!isset($pages[$id])){
$pages[$id] = new CompoundTag("", [
new StringTag(self::TAG_PAGE_TEXT, ""),
new StringTag(self::TAG_PAGE_PHOTONAME, "")
]);
}
for($current = $pagesTag->count(); $current <= $pageId; $current++){
$pagesTag->push(new CompoundTag("", [
new StringTag(self::TAG_PAGE_TEXT, ""),
new StringTag(self::TAG_PAGE_PHOTONAME, "")
]));
}
$this->setPages($pages);
$this->setNamedTagEntry($pagesTag);
}
/**
@ -129,10 +127,9 @@ class WritableBook extends Item{
* @return bool indicating success
*/
public function deletePage(int $pageId) : bool{
$pages = $this->getPages();
unset($pages[$pageId]);
$this->setPages(array_values($pages));
$pagesTag = $this->getPagesTag();
$pagesTag->remove($pageId);
$this->setNamedTagEntry($pagesTag);
return true;
}
@ -146,16 +143,14 @@ class WritableBook extends Item{
* @return bool indicating success
*/
public function insertPage(int $pageId, string $pageText = "") : bool{
$pages = $this->getPages();
$pagesTag = $this->getPagesTag();
$this->setPages(array_merge(
array_slice($pages, 0, $pageId),
[new CompoundTag("", [
new StringTag(self::TAG_PAGE_TEXT, $pageText),
new StringTag(self::TAG_PAGE_PHOTONAME, "")
])],
array_slice($pages, $pageId)
));
$pagesTag->insert($pageId, new CompoundTag("", [
new StringTag(self::TAG_PAGE_TEXT, $pageText),
new StringTag(self::TAG_PAGE_PHOTONAME, "")
]));
$this->setNamedTagEntry($pagesTag);
return true;
}
@ -199,6 +194,10 @@ class WritableBook extends Item{
return $pages->getValue();
}
protected function getPagesTag() : ListTag{
return $this->getNamedTag()->getListTag(self::TAG_PAGES) ?? new ListTag(self::TAG_PAGES, [], NBT::TAG_Compound);
}
/**
*
* @param CompoundTag[] $pages