mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-08 02:42:58 +00:00
Code Issues Projects Releases Wiki Activity

Avoid usage of for-loop vars outside of for-loop context

Browse Source 
these problems were reported by PHPStan strict rules. They aren't actually bugs, but they could become bugs in the future.
This commit is contained in:
Dylan K. Taylor
2020-02-05 13:16:09 +00:00
parent 88afedd1e8
commit 99038c752c
5 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/pocketmine/level/generator/populator/GroundCover.php
View File

@ -47,7 +47,8 @@ class GroundCover extends Populator{
}
$column = $chunk->getBlockIdColumn($x, $z);
for($y = 127; $y > 0; --$y){
$y = 127;
for(; $y > 0; --$y){
if($column[$y] !== "\x00" and !BlockFactory::get(ord($column[$y]))->isTransparent()){
break;
}

4
src/pocketmine/level/generator/populator/TallGrass.php
View File

@ -77,10 +77,10 @@ class TallGrass extends Populator{
for($y = 127; $y >= 0; --$y){
$b = $this->level->getBlockIdAt($x, $y, $z);
if($b !== Block::AIR and $b !== Block::LEAVES and $b !== Block::LEAVES2 and $b !== Block::SNOW_LAYER){
break;
return $y + 1;
}
}
return $y === 0 ? -1 : ++$y;
return -1;
}
}

4
src/pocketmine/level/generator/populator/Tree.php
View File

@ -83,12 +83,12 @@ class Tree extends Populator{
for($y = 127; $y > 0; --$y){
$b = $this->level->getBlockIdAt($x, $y, $z);
if($b === Block::DIRT or $b === Block::GRASS){
break;
return $y + 1;
}elseif($b !== Block::AIR and $b !== Block::SNOW_LAYER){
return -1;
}
}
return ++$y;
return -1;
}
}