mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 10:22:56 +00:00
Code Issues Projects Releases Wiki Activity

Isolate config casting nastiness in one place

Browse Source 
this doesn't solve the underlying problem, but it does reduce the amount of noise made by PHPStan about it, as well as avoiding code litter.
This commit is contained in:
Dylan K. Taylor
2021-06-19 19:14:02 +01:00
parent 11b483f2dc
commit 981b0285d1
13 changed files with 73 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/updater/AutoUpdater.php
View File

@ -55,7 +55,7 @@ class AutoUpdater{
$this->logger = new \PrefixedLogger($server->getLogger(), "Auto Updater");
$this->endpoint = "http://$endpoint/api/";
if((bool) $server->getConfigGroup()->getProperty("auto-updater.enabled", true)){
if($server->getConfigGroup()->getPropertyBool("auto-updater.enabled", true)){
$this->doCheck();
}
}
@ -72,7 +72,7 @@ class AutoUpdater{
$this->checkUpdate();
if($this->hasUpdate()){
(new UpdateNotifyEvent($this))->call();
if((bool) $this->server->getConfigGroup()->getProperty("auto-updater.on-update.warn-console", true)){
if($this->server->getConfigGroup()->getPropertyBool("auto-updater.on-update.warn-console", true)){
$this->showConsoleUpdate();
}
}else{
@ -178,7 +178,7 @@ class AutoUpdater{
* Returns the channel used for update checking (stable, beta, dev)
*/
public function getChannel() : string{
$channel = strtolower($this->server->getConfigGroup()->getProperty("auto-updater.preferred-channel", "stable"));
$channel = strtolower($this->server->getConfigGroup()->getPropertyString("auto-updater.preferred-channel", "stable"));
if($channel !== "stable" and $channel !== "beta" and $channel !== "alpha" and $channel !== "development"){
$channel = "stable";
}