mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-11 05:55:33 +00:00
Code Issues Projects Releases Wiki Activity

World: fixed original promise not getting fulfilled if the chunk became populated=true after a promise was already made (but not fulfilled) to populate it

Browse Source 
this could happen if a plugin calls setPopulated(true) on a chunk after a request for its population landed in the queue, but before it actually got processed. In that case, the promise would never get fulfilled.
This commit is contained in:
Dylan K. Taylor 2021-10-31 22:54:37 +00:00
parent 2fa0a914ff
commit 96cfdc79b8
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/world/World.php
View File

@ -2869,9 +2869,9 @@ class World implements ChunkManager{
$this->unregisterChunkLoader($temporaryChunkLoader, $x, $z); $this->unregisterChunkLoader($temporaryChunkLoader, $x, $z);
//chunk is already populated; return a pre-resolved promise that will directly fire callbacks assigned //chunk is already populated; return a pre-resolved promise that will directly fire callbacks assigned
$result = new PromiseResolver(); $resolver ??= new PromiseResolver();
$result->resolve($chunk); $resolver->resolve($chunk);
return $result->getPromise(); return $resolver->getPromise();
} }
/** /**