From 9651b3f470920cbc312f57ca669b80c9ffad30de Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Mon, 24 Sep 2018 16:48:19 +0100 Subject: [PATCH] Crops: micro optimization - check age before generating random number (faster) I don't have any idea how much benefit this will provide in real terms, but it may be significant. --- src/pocketmine/block/Crops.php | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/pocketmine/block/Crops.php b/src/pocketmine/block/Crops.php index e890fa3dd..66866180f 100644 --- a/src/pocketmine/block/Crops.php +++ b/src/pocketmine/block/Crops.php @@ -92,15 +92,13 @@ abstract class Crops extends Flowable{ } public function onRandomTick() : void{ - if(mt_rand(0, 2) === 1){ - if($this->age < 7){ - $block = clone $this; - ++$block->age; - Server::getInstance()->getPluginManager()->callEvent($ev = new BlockGrowEvent($this, $block)); + if($this->age < 7 and mt_rand(0, 2) === 1){ + $block = clone $this; + ++$block->age; + Server::getInstance()->getPluginManager()->callEvent($ev = new BlockGrowEvent($this, $block)); - if(!$ev->isCancelled()){ - $this->getLevel()->setBlock($this, $ev->getNewState(), true, true); - } + if(!$ev->isCancelled()){ + $this->getLevel()->setBlock($this, $ev->getNewState(), true, true); } } }