mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-03 00:25:04 +00:00
Code Issues Projects Releases Wiki Activity

Clean up confusing mess around block and item overriding

Browse Source 
right now, I don't see an obvious reason to do this. If it turns out I was wrong later on, we can add functionality back, but we can't remove functionality after release.
This commit is contained in:
Dylan K. Taylor
2023-05-17 15:21:49 +01:00
parent c9bb4335a1
commit 9621836e36
5 changed files with 11 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/phpunit/block/BlockTest.php
View File

@ -49,15 +49,6 @@ class BlockTest extends TestCase{
$this->blockFactory->register($block);
}
/**
* Test registering a block deliberately overwriting another block works as expected
*/
public function testDeliberateOverrideBlock() : void{
$block = new MyCustomBlock(new BlockIdentifier(BlockTypeIds::COBBLESTONE), "Cobblestone", new BlockTypeInfo(BlockBreakInfo::instant()));
$this->blockFactory->register($block, true);
self::assertInstanceOf(MyCustomBlock::class, $this->blockFactory->fromStateId($block->getStateId()));
}
/**
* Test registering a new block which does not yet exist
*/