mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-07 12:18:46 +00:00
Code Issues Projects Releases Wiki Activity

ContainerTrait: use a static-analysis-friendly way to read NBT, fixes 4 phpstan level 8 errors

Browse Source
This commit is contained in:
Dylan K. Taylor 2020-06-27 01:00:25 +01:00
parent f039a077cd
commit 9484220bd5
2 changed files with 1 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/block/tile/ContainerTrait.php
View File

@ -44,9 +44,7 @@ trait ContainerTrait{
abstract public function getRealInventory(); abstract public function getRealInventory();
protected function loadItems(CompoundTag $tag) : void{ protected function loadItems(CompoundTag $tag) : void{
if($tag->hasTag(Container::TAG_ITEMS, ListTag::class)){ if(($inventoryTag = $tag->getTag(Container::TAG_ITEMS)) instanceof ListTag){
$inventoryTag = $tag->getListTag(Container::TAG_ITEMS);
$inventory = $this->getRealInventory(); $inventory = $this->getRealInventory();
$listeners = $inventory->getListeners()->toArray(); $listeners = $inventory->getListeners()->toArray();
$inventory->getListeners()->remove(...$listeners); //prevent any events being fired by initialization $inventory->getListeners()->remove(...$listeners); //prevent any events being fired by initialization

20
tests/phpstan/configs/l8-baseline.neon
View File

@ -45,26 +45,6 @@ parameters:
count: 1 count: 1
path: ../../../src/block/tile/Chest.php path: ../../../src/block/tile/Chest.php
-
message: "#^Argument of an invalid type pocketmine\\\\nbt\\\\tag\\\\ListTag\\|null supplied for foreach, only iterables are supported\\.$#"
count: 1
path: ../../../src/block/tile/Chest.php
-
message: "#^Argument of an invalid type pocketmine\\\\nbt\\\\tag\\\\ListTag\\|null supplied for foreach, only iterables are supported\\.$#"
count: 1
path: ../../../src/block/tile/BrewingStand.php
-
message: "#^Argument of an invalid type pocketmine\\\\nbt\\\\tag\\\\ListTag\\|null supplied for foreach, only iterables are supported\\.$#"
count: 1
path: ../../../src/block/tile/Furnace.php
-
message: "#^Argument of an invalid type pocketmine\\\\nbt\\\\tag\\\\ListTag\\|null supplied for foreach, only iterables are supported\\.$#"
count: 1
path: ../../../src/block/tile/Hopper.php
- -
message: "#^Parameter \\#1 \\$nbt of method pocketmine\\\\block\\\\tile\\\\Tile\\:\\:readSaveData\\(\\) expects pocketmine\\\\nbt\\\\tag\\\\CompoundTag, pocketmine\\\\nbt\\\\tag\\\\CompoundTag\\|null given\\.$#" message: "#^Parameter \\#1 \\$nbt of method pocketmine\\\\block\\\\tile\\\\Tile\\:\\:readSaveData\\(\\) expects pocketmine\\\\nbt\\\\tag\\\\CompoundTag, pocketmine\\\\nbt\\\\tag\\\\CompoundTag\\|null given\\.$#"
count: 1 count: 1