mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-04-21 00:07:30 +00:00
Code Issues Projects Releases Wiki Activity

Fix lighting population, fix lighting issues when read by vanilla Minecraft

Browse Source
This commit is contained in:
Dylan K. Taylor 2017-01-13 11:33:55 +00:00
parent 085d1a1359
commit 946d301bc7
2 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/pocketmine/level/format/Chunk.php
View File

@ -437,21 +437,22 @@ class Chunk{
for($z = 0; $z < 16; ++$z){
$heightMap = $this->getHeightMap($x, $z);
$y = min(($this->getHighestSubChunkIndex() + 1) << 4, $heightMap);
$y = ($this->getHighestSubChunkIndex() + 1) << 4;
//TODO: replace a section of the array with a string in one call to improve performance
for(; $y > $heightMap; --$y){
$this->setBlockSkyLight($x, $y, $z, 15);
}
for(; $y > 0; --$y){
if($this->getBlockId($x, $y, $z) !== Block::AIR){
break;
}
for(; $y > 0 and $this->getBlockId($x, $y, $z) === Block::AIR; --$y){
$this->setBlockSkyLight($x, $y, $z, 15);
}
$this->setHeightMap($x, $z, $y);
for(; $y > 0; --$y){
$this->setBlockSkyLight($x, $y, $z, 0);
}
}
}
}

6
src/pocketmine/level/format/SubChunk.php
View File

@ -30,10 +30,10 @@ class SubChunk{
protected $blockLight;
protected $skyLight;
private static function assignData(&$target, $data, $length){
private static function assignData(&$target, $data, $length, $value = "\x00"){
if(strlen($data) !== $length){
assert($data === "", "Invalid non-zero length given, expected $length, got " . strlen($data));
$target = str_repeat("\x00", $length);
$target = str_repeat($value, $length);
}else{
$target = $data;
}
@ -42,7 +42,7 @@ class SubChunk{
public function __construct(string $ids = "", string $data = "", string $skyLight = "", string $blockLight = ""){
self::assignData($this->ids, $ids, 4096);
self::assignData($this->data, $data, 2048);
self::assignData($this->skyLight, $skyLight, 2048);
self::assignData($this->skyLight, $skyLight, 2048, "\xff");
self::assignData($this->blockLight, $blockLight, 2048);
}