mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-22 19:06:35 +00:00
Code Issues Projects Releases Wiki Activity

added a whole bunch of tests for enchantment handling

Browse Source
This commit is contained in:
Dylan K. Taylor 2019-02-20 14:43:57 +00:00
parent 7170d9009d
commit 9354929cad
2 changed files with 150 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

81
tests/phpunit/item/ItemFactoryTest.php Normal file
View File

@ -0,0 +1,81 @@
<?php
/*
*
* ____ _ _ __ __ _ __ __ ____
* | _ \ ___ ___| | _____| |_| \/ (_)_ __ ___ | \/ | _ \
* | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
* | __/ (_) | (__| < __/ |_| | | | | | | | __/_____| | | | __/
* |_| \___/ \___|_|\_\___|\__|_| |_|_|_| |_|\___| |_| |_|_|
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* @author PocketMine Team
* @link http://www.pocketmine.net/
*
*
*/
declare(strict_types=1);
namespace pocketmine\item;
use PHPUnit\Framework\TestCase;
use pocketmine\block\BlockFactory;
class ItemFactoryTest extends TestCase{
public function setUp() : void{
BlockFactory::init();
ItemFactory::init();
}
/**
* Tests that blocks are considered to be valid registered items
*/
public function testItemBlockRegistered() : void{
for($id = 0; $id < 256; ++$id){
self::assertEquals(BlockFactory::isRegistered($id), ItemFactory::isRegistered($id));
}
}
public function itemFromStringProvider() : array{
return [
["dye:4", ItemIds::DYE, 4],
["351", ItemIds::DYE, 0],
["351:4", ItemIds::DYE, 4],
["stone:3", ItemIds::STONE, 3],
["minecraft:string", ItemIds::STRING, 0],
["diamond_pickaxe", ItemIds::DIAMOND_PICKAXE, 0],
["diamond_pickaxe:5", ItemIds::DIAMOND_PICKAXE, 5]
];
}
/**
* @dataProvider itemFromStringProvider
* @param string $string
* @param int $id
* @param int $meta
*/
public function testFromStringSingle(string $string, int $id, int $meta) : void{
$item = ItemFactory::fromString($string);
self::assertEquals($id, $item->getId());
self::assertEquals($meta, $item->getDamage());
}
/**
* Test that durable items are correctly created by the item factory
*/
public function testGetDurableItem() : void{
self::assertInstanceOf(Sword::class, $i1 = ItemFactory::get(Item::WOODEN_SWORD));
/** @var Sword $i1 */
self::assertSame(0, $i1->getDamage());
self::assertInstanceOf(Sword::class, $i2 = ItemFactory::get(Item::WOODEN_SWORD, 1));
/** @var Sword $i2 */
self::assertSame(1, $i2->getDamage());
}
}

103
tests/phpunit/item/ItemTest.php
View File

@ -25,12 +25,22 @@ namespace pocketmine\item;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use pocketmine\block\BlockFactory; use pocketmine\block\BlockFactory;
use pocketmine\item\enchantment\Enchantment;
use pocketmine\item\enchantment\EnchantmentInstance;
class ItemTest extends TestCase{ class ItemTest extends TestCase{
public function setUp() : void{ public static function setUpBeforeClass() : void{
BlockFactory::init(); BlockFactory::init();
ItemFactory::init(); ItemFactory::init();
Enchantment::init();
}
/** @var Item */
private $item;
public function setUp() : void{
$this->item = ItemFactory::get(Item::DIAMOND_SWORD);
} }
/** /**
@ -52,45 +62,70 @@ class ItemTest extends TestCase{
self::assertTrue($item1->equals($item2)); self::assertTrue($item1->equals($item2));
} }
/** public function testHasEnchantment() : void{
* Tests that blocks are considered to be valid registered items $this->item->addEnchantment(new EnchantmentInstance(Enchantment::EFFICIENCY(), 5));
*/ self::assertTrue($this->item->hasEnchantment(Enchantment::EFFICIENCY()));
public function testItemBlockRegistered() : void{ self::assertTrue($this->item->hasEnchantment(Enchantment::EFFICIENCY(), 5));
for($id = 0; $id < 256; ++$id){
self::assertEquals(BlockFactory::isRegistered($id), ItemFactory::isRegistered($id));
}
} }
public function itemFromStringProvider() : array{ public function testHasEnchantments() : void{
return [ self::assertFalse($this->item->hasEnchantments());
["dye:4", ItemIds::DYE, 4], $this->item->addEnchantment(new EnchantmentInstance(Enchantment::FIRE_ASPECT()));
["351", ItemIds::DYE, 0], self::assertTrue($this->item->hasEnchantments());
["351:4", ItemIds::DYE, 4], }
["stone:3", ItemIds::STONE, 3],
["minecraft:string", ItemIds::STRING, 0], public function testGetEnchantmentLevel() : void{
["diamond_pickaxe", ItemIds::DIAMOND_PICKAXE, 0], $this->item->addEnchantment(new EnchantmentInstance(Enchantment::EFFICIENCY(), 5));
["diamond_pickaxe:5", ItemIds::DIAMOND_PICKAXE, 5] self::assertSame(5, $this->item->getEnchantmentLevel(Enchantment::EFFICIENCY()));
}
public function testGetEnchantments() : void{
/** @var EnchantmentInstance[] $enchantments */
$enchantments = [
new EnchantmentInstance(Enchantment::EFFICIENCY(), 5),
new EnchantmentInstance(Enchantment::SHARPNESS(), 1)
]; ];
foreach($enchantments as $enchantment){
$this->item->addEnchantment($enchantment);
}
foreach($this->item->getEnchantments() as $enchantment){
foreach($enchantments as $k => $applied){
if($enchantment->getType() === $applied->getType() and $enchantment->getLevel() === $applied->getLevel()){
unset($enchantments[$k]);
continue 2;
}
}
self::assertTrue(false, "Unknown extra enchantment found: " . $enchantment->getType()->getName() . " x" . $enchantment->getLevel());
}
self::assertEmpty($enchantments, "Expected all enchantments to be present");
} }
/** public function testOverwriteEnchantment() : void{
* @dataProvider itemFromStringProvider $this->item->addEnchantment(new EnchantmentInstance(Enchantment::SHARPNESS()));
* @param string $string $this->item->addEnchantment(new EnchantmentInstance(Enchantment::SHARPNESS(), 5));
* @param int $id self::assertSame(5, $this->item->getEnchantmentLevel(Enchantment::SHARPNESS()));
* @param int $meta
*/
public function testFromStringSingle(string $string, int $id, int $meta) : void{
$item = ItemFactory::fromString($string);
self::assertEquals($id, $item->getId());
self::assertEquals($meta, $item->getDamage());
} }
/** public function testRemoveAllEnchantments() : void{
* Test that durable items are correctly created by the item factory $this->item->addEnchantment(new EnchantmentInstance(Enchantment::FIRE_ASPECT()));
*/ self::assertCount(1, $this->item->getEnchantments());
public function testGetDurableItem() : void{ $this->item->removeEnchantments();
self::assertInstanceOf(Sword::class, ItemFactory::get(Item::WOODEN_SWORD)); self::assertEmpty($this->item->getEnchantments());
self::assertInstanceOf(Sword::class, ItemFactory::get(Item::WOODEN_SWORD, 1)); }
public function testRemoveEnchantment() : void{
$this->item->addEnchantment(new EnchantmentInstance(Enchantment::KNOCKBACK()));
$this->item->addEnchantment(new EnchantmentInstance(Enchantment::SHARPNESS()));
self::assertCount(2, $this->item->getEnchantments());
$this->item->removeEnchantment(Enchantment::SHARPNESS());
self::assertFalse($this->item->hasEnchantment(Enchantment::SHARPNESS()));
}
public function testRemoveEnchantmentLevel() : void{
$this->item->addEnchantment(new EnchantmentInstance(Enchantment::FIRE_ASPECT(), 2));
$this->item->addEnchantment(new EnchantmentInstance(Enchantment::UNBREAKING()));
self::assertCount(2, $this->item->getEnchantments());
$this->item->removeEnchantment(Enchantment::FIRE_ASPECT(), 2);
self::assertFalse($this->item->hasEnchantment(Enchantment::FIRE_ASPECT()));
} }
} }