From 15645759e92bcfa715e9f6df3410e83681f331f4 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Tue, 11 Oct 2022 22:47:54 +0100 Subject: [PATCH 1/8] Release 4.9.1 --- changelogs/4.9.md | 22 ++++++++++++++++++++++ src/VersionInfo.php | 2 +- 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/changelogs/4.9.md b/changelogs/4.9.md index 34b861657..6bbd5af8e 100644 --- a/changelogs/4.9.md +++ b/changelogs/4.9.md @@ -12,3 +12,25 @@ Released 20th September 2022. ## General - Added support for Minecraft: Bedrock Edition 1.19.30. - Removed support for older versions. + +# 4.9.1 +Released 11th October 2022. + +## Documentation +- Added and improved documentation for many API methods in `Player` and `Block`. +- Added missing `@internal` tag for `TaskHandler->setNextRun()`, `TaskHandler->remove()` and `TaskHandler->run()`. + +## Fixes +- Flight state is now locked by the server in spectator mode. This prevents any attempt by the client to toggle flight mode. +- Fixed entity health exceeding its max health after the expiry of Health Boost effect. +- Fixed burp sound not being played when a player eats food. +- Fixed placement conditions for mushrooms - they can now only be placed when the light level at the target is <= 12, or on podzol or mycelium. +- Fixed sign text appearing to change colour and/or glow when using dye on a sign - since this feature is not yet implemented, no change should occur. +- Fixed players drowning when sprint-swimming on the surface of water. + +## Internals +- Added more detailed debug logging during the player login sequence. +- Silenced debug spam during `PreSpawnPacketHandler`, considerably reducing debug noise when players join. +- Fixed an edge case in `InventoryManager->removeWindow()`. This bug didn't have any effect on stable versions, but caused a `next-minor` development version to crash. +- `Item`s returned by event getters are now cloned if modifying the result will have no useful side effects. +- Updated `pocketmine/bedrock-data` to [`1.11.1`](https://github.com/pmmp/BedrockData/tree/1.11.1%2Bbedrock-1.19.30), which reduces bandwidth consumption during logins by not sending useless biome generation data. diff --git a/src/VersionInfo.php b/src/VersionInfo.php index bfbcdb7fd..e2302f773 100644 --- a/src/VersionInfo.php +++ b/src/VersionInfo.php @@ -32,7 +32,7 @@ use function str_repeat; final class VersionInfo{ public const NAME = "PocketMine-MP"; public const BASE_VERSION = "4.9.1"; - public const IS_DEVELOPMENT_BUILD = true; + public const IS_DEVELOPMENT_BUILD = false; public const BUILD_CHANNEL = "stable"; private function __construct(){ From 293cea77144027e927f459046b356e0f389ff6da Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Tue, 11 Oct 2022 22:47:58 +0100 Subject: [PATCH 2/8] 4.9.2 is next --- src/VersionInfo.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/VersionInfo.php b/src/VersionInfo.php index e2302f773..83bf8f005 100644 --- a/src/VersionInfo.php +++ b/src/VersionInfo.php @@ -31,8 +31,8 @@ use function str_repeat; final class VersionInfo{ public const NAME = "PocketMine-MP"; - public const BASE_VERSION = "4.9.1"; - public const IS_DEVELOPMENT_BUILD = false; + public const BASE_VERSION = "4.9.2"; + public const IS_DEVELOPMENT_BUILD = true; public const BUILD_CHANNEL = "stable"; private function __construct(){ From 421379fc77aec8a78fd116c08c1a7137f9ecd1a7 Mon Sep 17 00:00:00 2001 From: IvanCraft623 <57236932+IvanCraft623@users.noreply.github.com> Date: Tue, 11 Oct 2022 16:57:35 -0500 Subject: [PATCH 3/8] SplashPotion: Use `World::getCollidingEntities()` instead of `World::getNearbyEntities()` (#5326) fixes spectator players receiving effects from splash potions --- src/entity/projectile/SplashPotion.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/entity/projectile/SplashPotion.php b/src/entity/projectile/SplashPotion.php index f9cee30a9..a942d9622 100644 --- a/src/entity/projectile/SplashPotion.php +++ b/src/entity/projectile/SplashPotion.php @@ -98,8 +98,8 @@ class SplashPotion extends Throwable{ if($hasEffects){ if(!$this->willLinger()){ - foreach($this->getWorld()->getNearbyEntities($this->boundingBox->expandedCopy(4.125, 2.125, 4.125), $this) as $entity){ - if($entity instanceof Living && $entity->isAlive()){ + foreach($this->getWorld()->getCollidingEntities($this->boundingBox->expandedCopy(4.125, 2.125, 4.125), $this) as $entity){ + if($entity instanceof Living){ $distanceSquared = $entity->getEyePos()->distanceSquared($this->location); if($distanceSquared > 16){ //4 blocks continue; From 0d29a138fb33e038f278262c0f24305f0245a16b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 13 Oct 2022 13:06:25 +0100 Subject: [PATCH 4/8] Bump docker/build-push-action from 3.1.1 to 3.2.0 (#5336) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3.1.1 to 3.2.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](https://github.com/docker/build-push-action/compare/v3.1.1...v3.2.0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/build-docker-image.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml index 8e1ba493e..ed2987473 100644 --- a/.github/workflows/build-docker-image.yml +++ b/.github/workflows/build-docker-image.yml @@ -46,7 +46,7 @@ jobs: run: echo ::set-output name=NAME::$(echo "${GITHUB_REPOSITORY,,}") - name: Build image for tag - uses: docker/build-push-action@v3.1.1 + uses: docker/build-push-action@v3.2.0 with: push: true context: ./pocketmine-mp @@ -59,7 +59,7 @@ jobs: - name: Build image for major tag if: steps.channel.outputs.CHANNEL == 'stable' - uses: docker/build-push-action@v3.1.1 + uses: docker/build-push-action@v3.2.0 with: push: true context: ./pocketmine-mp @@ -72,7 +72,7 @@ jobs: - name: Build image for minor tag if: steps.channel.outputs.CHANNEL == 'stable' - uses: docker/build-push-action@v3.1.1 + uses: docker/build-push-action@v3.2.0 with: push: true context: ./pocketmine-mp @@ -85,7 +85,7 @@ jobs: - name: Build image for latest tag if: steps.channel.outputs.CHANNEL == 'stable' - uses: docker/build-push-action@v3.1.1 + uses: docker/build-push-action@v3.2.0 with: push: true context: ./pocketmine-mp From c83f0896ac8226ad3a006c4d00b35bf8c477058b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 13 Oct 2022 13:07:03 +0100 Subject: [PATCH 5/8] Bump ncipollo/release-action from 1.10.0 to 1.11.1 (#5319) Bumps [ncipollo/release-action](https://github.com/ncipollo/release-action) from 1.10.0 to 1.11.1. - [Release notes](https://github.com/ncipollo/release-action/releases) - [Commits](https://github.com/ncipollo/release-action/compare/v1.10.0...v1.11.1) --- updated-dependencies: - dependency-name: ncipollo/release-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/draft-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-release.yml b/.github/workflows/draft-release.yml index 2d140eb5a..9c26c3ff1 100644 --- a/.github/workflows/draft-release.yml +++ b/.github/workflows/draft-release.yml @@ -69,7 +69,7 @@ jobs: ${{ github.workspace }}/build_info.json - name: Create draft release - uses: ncipollo/release-action@v1.10.0 + uses: ncipollo/release-action@v1.11.1 with: artifacts: ${{ github.workspace }}/PocketMine-MP.phar,${{ github.workspace }}/start.*,${{ github.workspace }}/build_info.json commit: ${{ github.sha }} From 4fadb63f67b8938873cde6a0c603cf6ddcf59eb7 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 13 Oct 2022 16:29:01 +0100 Subject: [PATCH 6/8] Bump build/php from `50062b5` to `14ed8ea` (#5337) Bumps [build/php](https://github.com/pmmp/php-build-scripts) from `50062b5` to `14ed8ea`. - [Release notes](https://github.com/pmmp/php-build-scripts/releases) - [Commits](https://github.com/pmmp/php-build-scripts/compare/50062b5861235fbb9fe6e5d5b30684f4cb464470...14ed8eaadd921407c87be4964a8726b22427e80e) --- updated-dependencies: - dependency-name: build/php dependency-type: direct:production ... Signed-off-by: dependabot[bot] Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- build/php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/php b/build/php index 50062b586..14ed8eaad 160000 --- a/build/php +++ b/build/php @@ -1 +1 @@ -Subproject commit 50062b5861235fbb9fe6e5d5b30684f4cb464470 +Subproject commit 14ed8eaadd921407c87be4964a8726b22427e80e From b84c110819020c56f5dc342e51b942dc364d8de1 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Thu, 13 Oct 2022 21:00:57 +0100 Subject: [PATCH 7/8] Fix CS according to newest php-cs-fixer --- src/network/mcpe/raklib/RakLibThreadCrashInfo.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/network/mcpe/raklib/RakLibThreadCrashInfo.php b/src/network/mcpe/raklib/RakLibThreadCrashInfo.php index 957afdacd..60e04b4b4 100644 --- a/src/network/mcpe/raklib/RakLibThreadCrashInfo.php +++ b/src/network/mcpe/raklib/RakLibThreadCrashInfo.php @@ -47,7 +47,6 @@ final class RakLibThreadCrashInfo{ return new self(null, $info["message"], $info["file"], $info["line"]); } - /** @return string|null */ public function getClass() : ?string{ return $this->class; } public function getMessage() : string{ return $this->message; } From 92e47b98f8eacccc3c443a5069d1a81023e19971 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Thu, 13 Oct 2022 21:02:39 +0100 Subject: [PATCH 8/8] Updated DevTools submodule to pmmp/DevTools@bd0fa048dae29bebe25ba76d8c58788e92418b67 --- tests/plugins/DevTools | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/plugins/DevTools b/tests/plugins/DevTools index 95921c6d8..bd0fa048d 160000 --- a/tests/plugins/DevTools +++ b/tests/plugins/DevTools @@ -1 +1 @@ -Subproject commit 95921c6d877cbe07921a20bcca436db76b0d8bda +Subproject commit bd0fa048dae29bebe25ba76d8c58788e92418b67