From 9204b119480e57d8d0bd4564fa7e69fa4e900430 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Sun, 29 Dec 2019 17:55:03 +0000 Subject: [PATCH] phpstan: 0.12.3 fixes for master --- tests/phpstan/configs/phpstan-bugs.neon | 27 +++++-------------------- 1 file changed, 5 insertions(+), 22 deletions(-) diff --git a/tests/phpstan/configs/phpstan-bugs.neon b/tests/phpstan/configs/phpstan-bugs.neon index 41e6f8bb3..6d2c8eb04 100644 --- a/tests/phpstan/configs/phpstan-bugs.neon +++ b/tests/phpstan/configs/phpstan-bugs.neon @@ -53,6 +53,11 @@ parameters: count: 1 path: ../../../src/item/ItemFactory.php + - + message: "#^If condition is always false\\.$#" + count: 1 + path: ../../../src/item/ItemFactory.php + - message: "#^Cannot access offset int on Ds\\\\Deque&iterable\\\\.$#" count: 2 @@ -69,29 +74,7 @@ parameters: count: 1 path: ../../../src/network/mcpe/protocol/types/entity/EntityMetadataCollection.php - - - message: "#^Instanceof between int and PharFileInfo will always evaluate to false\\.$#" - count: 1 - path: ../../../src/plugin/PharPluginLoader.php - - message: "#^Strict comparison using \\=\\=\\= between int\\<1, max\\> and 0 will always evaluate to false\\.$#" count: 1 path: ../../../src/utils/Config.php - - - - #ReflectionFunction::getClosureThis() should be nullable - message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" - count: 1 - path: ../../../src/utils/Utils.php - - - - #ReflectionFunction::getClosureScopeClass() should be nullable - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: ../../../src/utils/Utils.php - - - - message: "#^Strict comparison using \\=\\=\\= between int\\ and 4 will always evaluate to false\\.$#" - count: 1 - path: ../../../src/world/World.php