mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 10:22:56 +00:00
Code Issues Projects Releases Wiki Activity

Block: get rid of getRuntimeId()

Browse Source 
the runtime ID mapping should be non-global in case of multiple protocols.
This commit is contained in:
Dylan K. Taylor
2020-07-06 11:18:29 +01:00
parent ad99dc5884
commit 909f3f39de
10 changed files with 18 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/world/sound/EntityLandSound.php
View File

@ -26,6 +26,7 @@ namespace pocketmine\world\sound;
use pocketmine\block\Block;
use pocketmine\entity\Entity;
use pocketmine\math\Vector3;
use pocketmine\network\mcpe\convert\RuntimeBlockMapping;
use pocketmine\network\mcpe\protocol\LevelSoundEventPacket;
/**
@ -47,7 +48,7 @@ class EntityLandSound implements Sound{
return LevelSoundEventPacket::create(
LevelSoundEventPacket::SOUND_LAND,
$pos,
$this->blockLandedOn->getRuntimeId(),
RuntimeBlockMapping::getInstance()->toRuntimeId($this->blockLandedOn->getId(), $this->blockLandedOn->getMeta()),
$this->entity::getNetworkTypeId()
//TODO: does isBaby have any relevance here?
);