Unhackify Registry member cloning, fixes #3519

tests/phpunit/utils/CloningRegistryTraitTest.php

@@ -0,0 +1,55 @@
+<?php
+
+/*
+ *
+ *  ____            _        _   __  __ _                  __  __ ____
+ * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
+ * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
+ * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
+ * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * @author PocketMine Team
+ * @link http://www.pocketmine.net/
+ *
+ *
+*/
+
+declare(strict_types=1);
+
+namespace pocketmine\utils;
+
+use PHPUnit\Framework\TestCase;
+use pocketmine\block\VanillaBlocks;
+
+final class CloningRegistryTraitTest extends TestCase{
+
+	/**
+	 * @phpstan-return \Generator<int, array{\Closure() : \stdClass}, void, void>
+	 */
+	public function cloningRegistryMembersProvider() : \Generator{
+		yield [function() : \stdClass{ return TestCloningRegistry::TEST1(); }];
+		yield [function() : \stdClass{ return TestCloningRegistry::TEST2(); }];
+		yield [function() : \stdClass{ return TestCloningRegistry::TEST3(); }];
+	}
+
+	/**
+	 * @dataProvider cloningRegistryMembersProvider
+	 * @phpstan-param \Closure() : \stdClass $provider
+	 */
+	public function testEachMemberClone(\Closure $provider) : void{
+		self::assertNotSame($provider(), $provider(), "Cloning registry should never return the same object twice");
+	}
+
+	public function testGetAllClone() : void{
+		$list1 = TestCloningRegistry::getAll();
+		$list2 = TestCloningRegistry::getAll();
+		foreach($list1 as $k => $member){
+			self::assertNotSame($member, $list2[$k], "VanillaBlocks ought to clone its members");
+		}
+	}
+}