mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-06 09:56:06 +00:00
Code Issues Projects Releases Wiki Activity

Unhackify Registry member cloning, fixes #3519

Browse Source
This commit is contained in:
Dylan K. Taylor
2020-05-21 11:38:02 +01:00
parent 7aca41a530
commit 8ec2ba79de
6 changed files with 158 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/item/VanillaItems.php
View File

@ -23,8 +23,8 @@ declare(strict_types=1);
namespace pocketmine\item;
use pocketmine\utils\CloningRegistryTrait;
use pocketmine\utils\RegistryTrait;
use pocketmine\utils\Utils;
use function assert;
/**
@ -292,7 +292,7 @@ use function assert;
* @method static Skull ZOMBIE_HEAD()
*/
final class VanillaItems{
use RegistryTrait;
use CloningRegistryTrait;
private function __construct(){
//NOOP
@ -305,14 +305,14 @@ final class VanillaItems{
public static function fromString(string $name) : Item{
$result = self::_registryFromString($name);
assert($result instanceof Item);
return clone $result;
return $result;
}
/**
* @return Item[]
*/
public static function getAll() : array{
return Utils::cloneObjectArray(self::_registryGetAll());
return self::_registryGetAll();
}
protected static function setup() : void{