Effect: use promoted properties

src/entity/effect/Effect.php

@@ -29,31 +29,20 @@ use pocketmine\entity\Living;
 
 class Effect{
 
-	/** @var int */
-	protected $internalRuntimeId;
-	/** @var string */
-	protected $name;
-	/** @var Color */
-	protected $color;
-	/** @var bool */
-	protected $bad;
-	/** @var bool */
-	protected $hasBubbles;
-
 	/**
 	 * @param int    $internalRuntimeId Internal runtime ID, unique to this effect type. Used for comparisons.
 	 * @param string $name Translation key used for effect name
 	 * @param Color  $color Color of bubbles given by this effect
-	 * @param bool   $isBad Whether the effect is harmful
+	 * @param bool   $bad Whether the effect is harmful
 	 * @param bool   $hasBubbles Whether the effect has potion bubbles. Some do not (e.g. Instant Damage has its own particles instead of bubbles)
 	 */
-	public function __construct(int $internalRuntimeId, string $name, Color $color, bool $isBad = false, bool $hasBubbles = true){
+	public function __construct(
-		$this->internalRuntimeId = $internalRuntimeId;
+		protected int $internalRuntimeId,
-		$this->name = $name;
+		protected string $name,
-		$this->color = $color;
+		protected Color $color,
-		$this->bad = $isBad;
+		protected bool $bad = false,
-		$this->hasBubbles = $hasBubbles;
+		protected bool $hasBubbles = true
-	}
+	){}
 
 	/**
 	 * Returns a unique identifier for this effect type