mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-03 08:39:53 +00:00
Code Issues Projects Releases Wiki Activity

Level: rename poorly-named parameter of setChunk()

Browse Source 
this now has a mouthful of a name. I'd like to invert it, but I can't do that without silently breaking backwards compatibility, which is unacceptable.
This commit is contained in:
Dylan K. Taylor 2019-01-30 10:26:18 +00:00
parent 0f9fdf6442
commit 8e47a40b4c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/pocketmine/level/Level.php
View File

@ -2475,9 +2475,9 @@ class Level implements ChunkManager, Metadatable{
* @param int $chunkX * @param int $chunkX
* @param int $chunkZ * @param int $chunkZ
* @param Chunk|null $chunk * @param Chunk|null $chunk
* @param bool $unload * @param bool $deleteEntitiesAndTiles Whether to delete entities and tiles on the old chunk, or transfer them to the new one
*/ */
public function setChunk(int $chunkX, int $chunkZ, Chunk $chunk = null, bool $unload = true){ public function setChunk(int $chunkX, int $chunkZ, Chunk $chunk = null, bool $deleteEntitiesAndTiles = true){
if($chunk === null){ if($chunk === null){
return; return;
} }
@ -2488,7 +2488,7 @@ class Level implements ChunkManager, Metadatable{
$chunkHash = Level::chunkHash($chunkX, $chunkZ); $chunkHash = Level::chunkHash($chunkX, $chunkZ);
$oldChunk = $this->getChunk($chunkX, $chunkZ, false); $oldChunk = $this->getChunk($chunkX, $chunkZ, false);
if($oldChunk !== null and $oldChunk !== $chunk){ if($oldChunk !== null and $oldChunk !== $chunk){
if($unload){ if($deleteEntitiesAndTiles){
$this->unloadChunk($chunkX, $chunkZ, false, false); $this->unloadChunk($chunkX, $chunkZ, false, false);
}else{ }else{
foreach($oldChunk->getEntities() as $entity){ foreach($oldChunk->getEntities() as $entity){